Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Side by Side Diff: sandbox/win/src/unload_dll_test.cc

Issue 1294823003: Sandbox: Reenable tests that were flaking for being too slow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/win/scoped_handle.h" 5 #include "base/win/scoped_handle.h"
6 #include "sandbox/win/src/sandbox.h" 6 #include "sandbox/win/src/sandbox.h"
7 #include "sandbox/win/src/sandbox_factory.h" 7 #include "sandbox/win/src/sandbox_factory.h"
8 #include "sandbox/win/src/target_services.h" 8 #include "sandbox/win/src/target_services.h"
9 #include "sandbox/win/tests/common/controller.h" 9 #include "sandbox/win/tests/common/controller.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 22 matching lines...) Expand all
33 33
34 // Opens an event passed as the first parameter of argv. 34 // Opens an event passed as the first parameter of argv.
35 SBOX_TESTS_COMMAND int SimpleOpenEvent(int argc, wchar_t **argv) { 35 SBOX_TESTS_COMMAND int SimpleOpenEvent(int argc, wchar_t **argv) {
36 if (argc != 1) 36 if (argc != 1)
37 return SBOX_TEST_FAILED_TO_EXECUTE_COMMAND; 37 return SBOX_TEST_FAILED_TO_EXECUTE_COMMAND;
38 38
39 base::win::ScopedHandle event_open(::OpenEvent(SYNCHRONIZE, FALSE, argv[0])); 39 base::win::ScopedHandle event_open(::OpenEvent(SYNCHRONIZE, FALSE, argv[0]));
40 return event_open.Get() ? SBOX_TEST_SUCCEEDED : SBOX_TEST_FAILED; 40 return event_open.Get() ? SBOX_TEST_SUCCEEDED : SBOX_TEST_FAILED;
41 } 41 }
42 42
43 // Flaky on windows, see http://crbug.com/80569. 43 TEST(UnloadDllTest, BaselineAvicapDll) {
44 TEST(UnloadDllTest, DISABLED_BaselineAvicapDll) {
45 TestRunner runner; 44 TestRunner runner;
46 runner.SetTestState(BEFORE_REVERT); 45 runner.SetTestState(BEFORE_REVERT);
47 runner.SetTimeout(2000); 46 runner.SetTimeout(2000);
48 // Add a sync rule, because that ensures that the interception agent has 47 // Add a sync rule, because that ensures that the interception agent has
49 // more than one item in its internal table. 48 // more than one item in its internal table.
50 EXPECT_TRUE(runner.AddRule(TargetPolicy::SUBSYS_SYNC, 49 EXPECT_TRUE(runner.AddRule(TargetPolicy::SUBSYS_SYNC,
51 TargetPolicy::EVENTS_ALLOW_ANY, L"t0001")); 50 TargetPolicy::EVENTS_ALLOW_ANY, L"t0001"));
52 51
53 // Note for the puzzled: avicap32.dll is a 64-bit dll in 64-bit versions of 52 // Note for the puzzled: avicap32.dll is a 64-bit dll in 64-bit versions of
54 // windows so this test and the others just work. 53 // windows so this test and the others just work.
55 EXPECT_EQ(SBOX_TEST_SUCCEEDED, runner.RunTest(L"UseOneDLL L avicap32.dll")); 54 EXPECT_EQ(SBOX_TEST_SUCCEEDED, runner.RunTest(L"UseOneDLL L avicap32.dll"));
56 EXPECT_EQ(SBOX_TEST_SUCCEEDED, runner.RunTest(L"UseOneDLL B avicap32.dll")); 55 EXPECT_EQ(SBOX_TEST_SUCCEEDED, runner.RunTest(L"UseOneDLL B avicap32.dll"));
57 } 56 }
58 57
59 // Flaky on windows, see http://crbug.com/80569. 58 TEST(UnloadDllTest, UnloadAviCapDllNoPatching) {
60 TEST(UnloadDllTest, DISABLED_UnloadAviCapDllNoPatching) {
61 TestRunner runner; 59 TestRunner runner;
62 runner.SetTestState(BEFORE_REVERT); 60 runner.SetTestState(BEFORE_REVERT);
63 runner.SetTimeout(2000); 61 runner.SetTimeout(2000);
64 sandbox::TargetPolicy* policy = runner.GetPolicy(); 62 sandbox::TargetPolicy* policy = runner.GetPolicy();
65 policy->AddDllToUnload(L"avicap32.dll"); 63 policy->AddDllToUnload(L"avicap32.dll");
66 EXPECT_EQ(SBOX_TEST_FAILED, runner.RunTest(L"UseOneDLL L avicap32.dll")); 64 EXPECT_EQ(SBOX_TEST_FAILED, runner.RunTest(L"UseOneDLL L avicap32.dll"));
67 EXPECT_EQ(SBOX_TEST_FAILED, runner.RunTest(L"UseOneDLL B avicap32.dll")); 65 EXPECT_EQ(SBOX_TEST_FAILED, runner.RunTest(L"UseOneDLL B avicap32.dll"));
68 } 66 }
69 67
70 // Flaky: http://crbug.com/38404 68 // Flaky: http://crbug.com/38404
(...skipping 16 matching lines...) Expand all
87 EXPECT_TRUE(runner.AddRule(TargetPolicy::SUBSYS_SYNC, 85 EXPECT_TRUE(runner.AddRule(TargetPolicy::SUBSYS_SYNC,
88 TargetPolicy::EVENTS_ALLOW_ANY, L"tst0001")); 86 TargetPolicy::EVENTS_ALLOW_ANY, L"tst0001"));
89 87
90 EXPECT_EQ(SBOX_TEST_FAILED, runner.RunTest(L"UseOneDLL L avicap32.dll")); 88 EXPECT_EQ(SBOX_TEST_FAILED, runner.RunTest(L"UseOneDLL L avicap32.dll"));
91 89
92 runner.SetTestState(AFTER_REVERT); 90 runner.SetTestState(AFTER_REVERT);
93 EXPECT_EQ(SBOX_TEST_SUCCEEDED, runner.RunTest(L"SimpleOpenEvent tst0001")); 91 EXPECT_EQ(SBOX_TEST_SUCCEEDED, runner.RunTest(L"SimpleOpenEvent tst0001"));
94 } 92 }
95 93
96 } // namespace sandbox 94 } // namespace sandbox
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698