Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1294803004: Native context: run prologue.js before runtime.js (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Native context: run prologue.js before runtime.js R=mvstanton@chromium.org Committed: https://crrev.com/f3059c43a49f10a97c91421b219801c75e69a680 Cr-Commit-Position: refs/heads/master@{#30217}

Patch Set 1 #

Patch Set 2 : also change BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -36 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 2 chunks +14 lines, -15 lines 0 comments Download
M src/prologue.js View 2 chunks +1 line, -19 lines 0 comments Download
M src/runtime.js View 2 chunks +8 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-internal.cc View 2 chunks +37 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 1296163003 Patch 1

Messages

Total messages: 6 (1 generated)
Yang
5 years, 4 months ago (2015-08-18 09:16:17 UTC) #1
mvstanton
lgtm
5 years, 4 months ago (2015-08-18 10:45:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294803004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294803004/20001
5 years, 4 months ago (2015-08-18 10:50:34 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-18 11:15:38 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 11:16:01 UTC) #6
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f3059c43a49f10a97c91421b219801c75e69a680
Cr-Commit-Position: refs/heads/master@{#30217}

Powered by Google App Engine
This is Rietveld 408576698