Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1296163003: Native context: install JS builtins via container object. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@prologuefirst
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Native context: install JS builtins via container object. Instead of installing them on the JS builtins object and later grab them from there. R=mvstanton@chromium.org Committed: https://crrev.com/d0225c832d3a650c4dafb8dda93280169c38df16 Cr-Commit-Position: refs/heads/master@{#30248}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -105 lines) Patch
M src/bootstrapper.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 4 chunks +18 lines, -15 lines 0 comments Download
M src/runtime.js View 38 chunks +90 lines, -90 lines 0 comments Download
M src/runtime/runtime.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Yang
5 years, 4 months ago (2015-08-18 09:48:19 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296163003/1
5 years, 4 months ago (2015-08-18 14:07:31 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/7055) v8_linux64_avx2_rel on ...
5 years, 4 months ago (2015-08-18 14:08:12 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296163003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296163003/20001
5 years, 4 months ago (2015-08-19 07:46:55 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-19 08:52:44 UTC) #9
Yang
On 2015/08/19 08:52:44, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 4 months ago (2015-08-19 08:54:24 UTC) #10
mvstanton
lgtm
5 years, 4 months ago (2015-08-19 10:54:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296163003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296163003/20001
5 years, 4 months ago (2015-08-19 12:09:58 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-19 12:49:01 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 12:49:19 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d0225c832d3a650c4dafb8dda93280169c38df16
Cr-Commit-Position: refs/heads/master@{#30248}

Powered by Google App Engine
This is Rietveld 408576698