Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1294783002: Remove grab-bag includes of v8.h from regexp engine. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-ic
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove grab-bag includes of v8.h from regexp engine. R=yangguo@chromium.org Committed: https://crrev.com/2421f9c39b82e4324e11e58c9ff7f159766a565b Cr-Commit-Position: refs/heads/master@{#30180}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -31 lines) Patch
M src/regexp/arm/regexp-macro-assembler-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/regexp/arm64/regexp-macro-assembler-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/regexp/ia32/regexp-macro-assembler-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/regexp/interpreter-irregexp.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/regexp/interpreter-irregexp.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/regexp/jsregexp.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/regexp/mips/regexp-macro-assembler-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/regexp/mips64/regexp-macro-assembler-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/regexp/ppc/regexp-macro-assembler-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/regexp/regexp-macro-assembler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/regexp/regexp-macro-assembler-irregexp.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/regexp/regexp-macro-assembler-tracer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/regexp/regexp-stack.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/regexp/regexp-stack.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/regexp/x64/regexp-macro-assembler-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/regexp/x87/regexp-macro-assembler-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1293793002 Patch 20001

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-14 13:59:24 UTC) #1
Yang
On 2015/08/14 13:59:24, Michael Starzinger wrote: lgtm.
5 years, 4 months ago (2015-08-14 14:00:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294783002/1
5 years, 4 months ago (2015-08-14 14:58:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 15:09:31 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 15:09:44 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2421f9c39b82e4324e11e58c9ff7f159766a565b
Cr-Commit-Position: refs/heads/master@{#30180}

Powered by Google App Engine
This is Rietveld 408576698