Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1293793002: Remove grab-bag includes of v8.h from IC subsystem. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove grab-bag includes of v8.h from IC subsystem. R=jkummerow@chromium.org Committed: https://crrev.com/0c5fbd393e05da87688bdf2ab429254e5023a73f Cr-Commit-Position: refs/heads/master@{#30178}

Patch Set 1 #

Patch Set 2 : Fix compilation on ARM and MIPS64. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -95 lines) Patch
M src/arm/constants-arm.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/ic/access-compiler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/arm/access-compiler-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/arm/ic-compiler-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/arm/stub-cache-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/arm64/access-compiler-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/arm64/ic-compiler-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/arm64/stub-cache-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/call-optimization.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/ia32/access-compiler-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/ia32/ic-compiler-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/ia32/stub-cache-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic-compiler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/ic-state.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/mips/access-compiler-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/mips/ic-compiler-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ic/mips/stub-cache-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/mips64/access-compiler-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/mips64/ic-compiler-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ic/mips64/stub-cache-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/ppc/access-compiler-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/ppc/ic-compiler-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/ppc/ic-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/ppc/stub-cache-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/stub-cache.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/x64/access-compiler-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/x64/ic-compiler-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/x64/stub-cache-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/x87/access-compiler-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/x87/ic-compiler-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/x87/ic-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/x87/stub-cache-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/constants-mips64.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1294783002 Patch 1

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-14 12:53:27 UTC) #1
Jakob Kummerow
LGTM!
5 years, 4 months ago (2015-08-14 12:56:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293793002/20001
5 years, 4 months ago (2015-08-14 13:24:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-14 13:33:37 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 13:33:52 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0c5fbd393e05da87688bdf2ab429254e5023a73f
Cr-Commit-Position: refs/heads/master@{#30178}

Powered by Google App Engine
This is Rietveld 408576698