[heap] Hide GCTracer inside the heap component.

[heap] Hide GCTracer inside the heap component.

This prevents leakage of the gc-tracer.h declarations inside of the
heap and prevents it from being exposed to the world. Protects private
state from being inadvertently mocked with.

R=mlippautz@chromium.org

Committed: https://crrev.com/1a3c7e2fb139e23abcb5de9124734ebdf40ebd5a
Cr-Commit-Position: refs/heads/master@{#30276}

[Michael Lippautz, 2015-08-20 15:09:08]

lgtm, thanks a lot!

https://codereview.chromium.org/1294763004/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1294763004/diff/1/src/heap/heap.h#newcode1346
src/heap/heap.h:1346: GCTracer* tracer() { return tracer_; }
Suggestion: GCTracer& ?

[Michael Starzinger, 2015-08-20 15:46:32]

https://codereview.chromium.org/1294763004/diff/1/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/1294763004/diff/1/src/heap/heap.h#newcode1346
src/heap/heap.h:1346: GCTracer* tracer() { return tracer_; }
On 2015/08/20 15:09:07, Michael Lippautz wrote:
> Suggestion: GCTracer& ?

Acknowledged. As discussed offline, let's do this in a separate CL, because
there are a gazillion call-site of this getter.

[Michael Starzinger, 2015-08-20 15:46:40]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2015-08-20 15:46:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1294763004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1294763004/1

[commit-bot: I haz the power, 2015-08-20 15:48:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-20 15:48:19]

Patchset 1 (id:??) landed as
https://crrev.com/1a3c7e2fb139e23abcb5de9124734ebdf40ebd5a
Cr-Commit-Position: refs/heads/master@{#30276}