Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1288913003: [heap] Hide MemoryReducer inside the heap component. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
Michael Lippautz
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-heap-gc-tracer
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Hide MemoryReducer inside the heap component. This prevents leakage of the memory-reducer.h declarations inside of the heap and prevents it from being exposed to the world. Protects private state from being inadvertently mocked with. R=mlippautz@chromium.org Committed: https://crrev.com/de57a6c0609aa9ab43cea474d252178ba044d448 Cr-Commit-Position: refs/heads/master@{#30277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M src/heap/heap.h View 3 chunks +2 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 7 chunks +12 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-20 15:54:01 UTC) #1
Michael Lippautz
lgtm
5 years, 4 months ago (2015-08-20 16:45:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288913003/1
5 years, 4 months ago (2015-08-20 16:47:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-20 16:48:45 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 16:48:58 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de57a6c0609aa9ab43cea474d252178ba044d448
Cr-Commit-Position: refs/heads/master@{#30277}

Powered by Google App Engine
This is Rietveld 408576698