DescriptionRevert of Move dispatchDidFirstVisuallyNonEmptyLayout into WebViewImpl. (patchset #2 id:20001 of https://codereview.chromium.org/1295053002/ )
Reason for revert:
Looks like it caused a race in:
ProfileErrorBrowserTestInstance/ProfileErrorBrowserTest.CorruptedProfile
Original issue's description:
> Move dispatchDidFirstVisuallyNonEmptyLayout into WebViewImpl.
>
> This removes the last user of didLayoutWithPendingStylesheets() and instead moves
> the call to dispatchDidFirstVisuallyNonEmptyLayout into WebViewImpl so the
> notification to the embedder is tied to the pumping of frames. This changes the
> behavior of this notification to only dispatch for the top level frame,
> but Chromium already has a check for that:
>
> https://chromium.googlesource.com/chromium/src/+/976d4d9a2735bdc11e5a641c84b6382566d48f1d/content/renderer/render_frame_impl.cc#3472
>
> RenderFrameImpl::didFirstVisuallyNonEmptyLayout's first check is
>
> if (frame->parent())
> return;
>
> so we already ignore all frames that are not the main frame. Future patches will
> clean up this interface so it's obvious this really only happens for the main
> frame.
>
> BUG=521692
> R=dglazkov@chromium.org
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200664
TBR=dglazkov@chromium.org,ojan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=521692
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200669
Patch Set 1 #
Created: 5 years, 4 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|