Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1294683004: Revert of Move dispatchDidFirstVisuallyNonEmptyLayout into WebViewImpl. (Closed)

Created:
5 years, 4 months ago by esprehn
Modified:
5 years, 4 months ago
Reviewers:
dglazkov, ojan
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Move dispatchDidFirstVisuallyNonEmptyLayout into WebViewImpl. (patchset #2 id:20001 of https://codereview.chromium.org/1295053002/ ) Reason for revert: Looks like it caused a race in: ProfileErrorBrowserTestInstance/ProfileErrorBrowserTest.CorruptedProfile Original issue's description: > Move dispatchDidFirstVisuallyNonEmptyLayout into WebViewImpl. > > This removes the last user of didLayoutWithPendingStylesheets() and instead moves > the call to dispatchDidFirstVisuallyNonEmptyLayout into WebViewImpl so the > notification to the embedder is tied to the pumping of frames. This changes the > behavior of this notification to only dispatch for the top level frame, > but Chromium already has a check for that: > > https://chromium.googlesource.com/chromium/src/+/976d4d9a2735bdc11e5a641c84b6382566d48f1d/content/renderer/render_frame_impl.cc#3472 > > RenderFrameImpl::didFirstVisuallyNonEmptyLayout's first check is > > if (frame->parent()) > return; > > so we already ignore all frames that are not the main frame. Future patches will > clean up this interface so it's obvious this really only happens for the main > frame. > > BUG=521692 > R=dglazkov@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200664 TBR=dglazkov@chromium.org,ojan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=521692 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -19 lines) Patch
M Source/core/frame/FrameView.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 3 chunks +14 lines, -5 lines 0 comments Download
M Source/web/WebViewImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 4 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
esprehn
Created Revert of Move dispatchDidFirstVisuallyNonEmptyLayout into WebViewImpl.
5 years, 4 months ago (2015-08-17 21:22:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294683004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294683004/1
5 years, 4 months ago (2015-08-17 21:22:57 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 21:23:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200669

Powered by Google App Engine
This is Rietveld 408576698