Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1294553003: Move GrRectBatch to GrBWFillRectBatch and make internal (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move GrRectBatch to GrBWFillRectBatch and make internal BUG=skia: Committed: https://skia.googlesource.com/skia/+/9c80b5ff592caf1c18b43e98c85bc8340b3ac531

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -308 lines) Patch
M gyp/gpu.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
A + src/gpu/batches/GrBWFillRectBatch.h View 2 chunks +5 lines, -10 lines 0 comments Download
A src/gpu/batches/GrBWFillRectBatch.cpp View 1 chunk +269 lines, -0 lines 1 comment Download
D src/gpu/batches/GrRectBatch.h View 1 chunk +0 lines, -84 lines 0 comments Download
D src/gpu/batches/GrRectBatch.cpp View 1 chunk +0 lines, -175 lines 0 comments Download
M src/gpu/batches/GrRectBatchFactory.h View 2 chunks +12 lines, -9 lines 0 comments Download
M src/gpu/batches/GrRectBatchFactory.cpp View 2 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294553003/1
5 years, 4 months ago (2015-08-13 16:42:22 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-08-13 16:42:23 UTC) #3
joshualitt
5 years, 4 months ago (2015-08-13 16:42:32 UTC) #5
bsalomon
Assuming the code is a straight copy (I didn't look closely), lgtm https://codereview.chromium.org/1294553003/diff/1/src/gpu/batches/GrBWFillRectBatch.cpp File src/gpu/batches/GrBWFillRectBatch.cpp ...
5 years, 4 months ago (2015-08-13 17:04:16 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 17:05:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9c80b5ff592caf1c18b43e98c85bc8340b3ac531

Powered by Google App Engine
This is Rietveld 408576698