Add GM to test drawing atlas case

Add GM to test drawing atlas case

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/2ba70995f8a69285dd35968aa3a3e19d5429bdd0

[joshualitt, 2015-08-13 15:48:56]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com

[joshualitt, 2015-08-13 15:48:57]

ptal

[joshualitt, 2015-08-13 17:59:34]

joshualitt@google.com changed reviewers:
+ robertphillips@google.com

[joshualitt, 2015-08-13 17:59:46]

adding Robert as well

[robertphillips, 2015-08-13 18:17:52]

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.cpp
File gm/drawminibitmaprect.cpp (right):

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:1: /*
2015 ?

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:8: #include "gm.h"
Do we need the blur headers ?

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:22: 
Can we pass the GM's canvas in here and use newSurface and newImageSnapshot?
This would be similar to the pattern used in the drawatlas GM.

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:31: 
const ?

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:33: 
const ?

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:35: 
const ?
static ?

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:40: 
const ?
static ?

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:48: 
SkASSERT(SK_ARRAY_COUNT(colors) == SK_ARRAY_COUNT(pos)); ?
Maybe a static assert ?

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:71: 
// This GM calls drawImageRect several times using the same texture. This is
intended to exercise batching of these calls.
?

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:81: bool                  fAA;
Do we need to keep fLargeBitmap around?

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:95: void onDraw(SkCanvas* canvas) override {
const ?

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:103: canvas->translate(SkIntToScalar(kPadX),
SkIntToScalar(kPadY));
Is there a restore to match this ?

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:111: 
const ?

[joshualitt, 2015-08-13 19:31:27]

feedback inc

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.cpp
File gm/drawminibitmaprect.cpp (right):

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:1: /*
On 2015/08/13 18:17:52, robertphillips wrote:
> 2015 ?

Acknowledged.

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:8: #include "gm.h"
On 2015/08/13 18:17:51, robertphillips wrote:
> Do we need the blur headers ?

Acknowledged.

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:31: 
On 2015/08/13 18:17:52, robertphillips wrote:
> const ?

Acknowledged.

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:33: 
On 2015/08/13 18:17:52, robertphillips wrote:
> const ?

Acknowledged.

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:35: 
On 2015/08/13 18:17:52, robertphillips wrote:
> const ?
> static ?

Acknowledged.

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:40: 
On 2015/08/13 18:17:52, robertphillips wrote:
> const ?
> static ?

Acknowledged.

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:48: 
On 2015/08/13 18:17:51, robertphillips wrote:
> SkASSERT(SK_ARRAY_COUNT(colors) == SK_ARRAY_COUNT(pos)); ?
> Maybe a static assert ?

Acknowledged.

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:71: 
On 2015/08/13 18:17:52, robertphillips wrote:
> // This GM calls drawImageRect several times using the same texture. This is
> intended to exercise batching of these calls.
> ?

Acknowledged.

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:81: bool                  fAA;
On 2015/08/13 18:17:52, robertphillips wrote:
> Do we need to keep fLargeBitmap around?

Acknowledged.

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:95: void onDraw(SkCanvas* canvas) override {
On 2015/08/13 18:17:52, robertphillips wrote:
> const ?

Acknowledged.

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:103: canvas->translate(SkIntToScalar(kPadX),
SkIntToScalar(kPadY));
On 2015/08/13 18:17:52, robertphillips wrote:
> Is there a restore to match this ?

Acknowledged.

https://codereview.chromium.org/1294513002/diff/40001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:111: 
On 2015/08/13 18:17:52, robertphillips wrote:
> const ?

Acknowledged.

[robertphillips, 2015-08-14 12:43:36]

lgtm

https://codereview.chromium.org/1294513002/diff/60001/gm/drawminibitmaprect.cpp
File gm/drawminibitmaprect.cpp (right):

https://codereview.chromium.org/1294513002/diff/60001/gm/drawminibitmaprect.c...
gm/drawminibitmaprect.cpp:75: 
Make these private ?

[joshualitt, 2015-08-14 13:23:23]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-08-14 13:23:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1294513002/#ps80001
(title: "make private")

[commit-bot: I haz the power, 2015-08-14 13:23:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1294513002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1294513002/80001

[commit-bot: I haz the power, 2015-08-14 13:30:53]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/2ba70995f8a69285dd35968aa3a3e19d5429bdd0