drawBitmapImage can batch across AA rects

drawBitmapImage can batch across AA rects

BUG=464835
Committed: https://skia.googlesource.com/skia/+/0d4bcea0d570041434ac3de2df2bd9063138fdb5

Committed: https://skia.googlesource.com/skia/+/a61c817272c4e0e4dac9d8e24226d0881e27c5c1

[joshualitt, 2015-08-13 16:10:24]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com

[joshualitt, 2015-08-13 16:10:24]

ptal

[bsalomon, 2015-08-13 17:00:34]

https://codereview.chromium.org/1293543002/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/1293543002/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:991: SkMatrix modelToUV;
Let's keep are labeling consistent and not introduce new names for existing
coordinate systems ("model" and "uv"). 

positionsToLocalCoords?

srcRectToDstRectMatrix?

[joshualitt, 2015-08-13 17:12:46]

On 2015/08/13 17:00:34, bsalomon wrote:
> https://codereview.chromium.org/1293543002/diff/1/src/gpu/SkGpuDevice.cpp
> File src/gpu/SkGpuDevice.cpp (right):
> 
>
https://codereview.chromium.org/1293543002/diff/1/src/gpu/SkGpuDevice.cpp#new...
> src/gpu/SkGpuDevice.cpp:991: SkMatrix modelToUV;
> Let's keep are labeling consistent and not introduce new names for existing
> coordinate systems ("model" and "uv"). 
> 
> positionsToLocalCoords?
> 
> srcRectToDstRectMatrix?

renamed

[bsalomon, 2015-08-13 17:55:05]

lgtm

[joshualitt, 2015-08-13 17:55:56]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-08-13 17:56:01]

The CQ bit was unchecked by joshualitt@google.com

[joshualitt, 2015-08-14 14:28:01]

joshualitt@google.com changed reviewers:
+ robertphillips@google.com

[joshualitt, 2015-08-14 16:32:10]

adding robert

[robertphillips, 2015-08-14 18:49:20]

lgtm + questions

https://codereview.chromium.org/1293543002/diff/60001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/1293543002/diff/60001/src/gpu/SkGpuDevice.cpp...
src/gpu/SkGpuDevice.cpp:1024:
paintWithShader.setShader(SkShader::CreateBitmapShader(*bitmapPtr,
tab over to line up with '(' ?

https://codereview.chromium.org/1293543002/diff/60001/src/gpu/SkGpuDevice.cpp...
src/gpu/SkGpuDevice.cpp:1029: } else {
Can/should this be a subroutine ?

[joshualitt, 2015-08-17 13:53:09]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-08-17 13:53:10]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com,
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1293543002/#ps80001
(title: "feedback inc")

[commit-bot: I haz the power, 2015-08-17 13:53:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1293543002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1293543002/80001

[commit-bot: I haz the power, 2015-08-17 13:59:42]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/0d4bcea0d570041434ac3de2df2bd9063138fdb5

[joshualitt, 2015-08-17 14:20:49]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1291663005/ by joshualitt@google.com.

The reason for reverting is: a follow up patch exposes a bug.

[joshualitt, 2015-08-17 17:02:52]

ptal

[robertphillips, 2015-08-17 17:26:01]

lgtm

[joshualitt, 2015-08-17 17:42:14]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-08-17 17:42:14]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1293543002/#ps120001
(title: "tweaks")

[commit-bot: I haz the power, 2015-08-17 17:42:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1293543002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1293543002/120001

[commit-bot: I haz the power, 2015-08-17 17:51:26]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/a61c817272c4e0e4dac9d8e24226d0881e27c5c1

[mtklein_C, 2015-08-24 19:42:39]

mtklein@chromium.org changed reviewers:
+ mtklein@chromium.org

[mtklein_C, 2015-08-24 19:42:40]

perf.skia.org has picked this out a nice win!  Way to go.

https://perf.skia.org/#3964