chrome/browser/favicon/favicon_tab_helper.cc - Issue 12945007: Fix Notifications Icon loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_tab_helper.cc

Issue 12945007: Fix Notifications Icon loading. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: patch for landing Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/favicon/favicon_tab_helper.cc

diff --git a/chrome/browser/favicon/favicon_tab_helper.cc b/chrome/browser/favicon/favicon_tab_helper.cc

index 9163926f08751cbccf94d3c27f87687a7cf5fb99..8d17dcd48ec318cb38759b466c8d2d31a1082909 100644

--- a/chrome/browser/favicon/favicon_tab_helper.cc

+++ b/chrome/browser/favicon/favicon_tab_helper.cc

@@ -132,9 +132,11 @@ NavigationEntry* FaviconTabHelper::GetActiveEntry() {

}

int FaviconTabHelper::StartDownload(const GURL& url, int image_size) {

- return web_contents()->DownloadFavicon(url, image_size,

- base::Bind(&FaviconTabHelper::DidDownloadFavicon,

- base::Unretained(this)));

+ return web_contents()->DownloadFavicon(

+ url,

+ true,

+ image_size,

+ base::Bind(&FaviconTabHelper::DidDownloadFavicon,base::Unretained(this)));

}

void FaviconTabHelper::NotifyFaviconUpdated(bool icon_url_changed) {