Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: android_webview/browser/icon_helper.cc

Issue 12945007: Fix Notifications Icon loading. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: patch for landing Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/icon_helper.cc
diff --git a/android_webview/browser/icon_helper.cc b/android_webview/browser/icon_helper.cc
index 9690df8f2e861831020663feec6cfcefb2d8c00f..395733099e7aa980b23a4c4e1444a65b0cfcc3db 100644
--- a/android_webview/browser/icon_helper.cc
+++ b/android_webview/browser/icon_helper.cc
@@ -59,8 +59,11 @@ void IconHelper::DidUpdateFaviconURL(int32 page_id,
// TODO(acleung): only fetch the URL if favicon downloading is enabled.
// (currently that is, the app has called WebIconDatabase.open()
// but we should decouple that setting via a boolean setting)
- web_contents()->DownloadFavicon(i->icon_url, 0, base::Bind(
- &IconHelper::DownloadFaviconCallback, base::Unretained(this)));
+ web_contents()->DownloadFavicon(i->icon_url,
+ true,
+ 0,
+ base::Bind(
+ &IconHelper::DownloadFaviconCallback, base::Unretained(this)));
break;
case content::FaviconURL::TOUCH_ICON:
if (listener_)
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698