Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/favicon/favicon_tab_helper.cc

Issue 12945007: Fix Notifications Icon loading. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tiny fix Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« android_webview/browser/icon_helper.cc ('K') | « android_webview/browser/icon_helper.cc ('k') | chrome/browser/notifications/message_center_notification_manager.cc » ('j') | chrome/browser/notifications/message_center_notification_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_tab_helper.cc
diff --git a/chrome/browser/favicon/favicon_tab_helper.cc b/chrome/browser/favicon/favicon_tab_helper.cc
index 9163926f08751cbccf94d3c27f87687a7cf5fb99..eb80ba393809e7042e5355ea1d574f484a7aafe8 100644
--- a/chrome/browser/favicon/favicon_tab_helper.cc
+++ b/chrome/browser/favicon/favicon_tab_helper.cc
@@ -132,9 +132,11 @@ NavigationEntry* FaviconTabHelper::GetActiveEntry() {
}
int FaviconTabHelper::StartDownload(const GURL& url, int image_size) {
- return web_contents()->DownloadFavicon(url, image_size,
- base::Bind(&FaviconTabHelper::DidDownloadFavicon,
- base::Unretained(this)));
+ return web_contents()->DownloadFavicon(
+ url,
+ true, // favicon
jam 2013/03/20 02:44:42 ditto
+ image_size,
+ base::Bind(&FaviconTabHelper::DidDownloadFavicon,base::Unretained(this)));
}
void FaviconTabHelper::NotifyFaviconUpdated(bool icon_url_changed) {
« android_webview/browser/icon_helper.cc ('K') | « android_webview/browser/icon_helper.cc ('k') | chrome/browser/notifications/message_center_notification_manager.cc » ('j') | chrome/browser/notifications/message_center_notification_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698