android_webview/browser/icon_helper.cc - Issue 12945007: Fix Notifications Icon loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/icon_helper.cc

Issue 12945007: Fix Notifications Icon loading. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tiny fix Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/browser/icon_helper.cc

diff --git a/android_webview/browser/icon_helper.cc b/android_webview/browser/icon_helper.cc

index 9690df8f2e861831020663feec6cfcefb2d8c00f..d017d0568b8da6b4c8c7db7e763ab5a268550ab0 100644

--- a/android_webview/browser/icon_helper.cc

+++ b/android_webview/browser/icon_helper.cc

@@ -59,8 +59,11 @@ void IconHelper::DidUpdateFaviconURL(int32 page_id,

// TODO(acleung): only fetch the URL if favicon downloading is enabled.

// (currently that is, the app has called WebIconDatabase.open()

// but we should decouple that setting via a boolean setting)

- web_contents()->DownloadFavicon(i->icon_url, 0, base::Bind(

- &IconHelper::DownloadFaviconCallback, base::Unretained(this)));

+ web_contents()->DownloadFavicon(i->icon_url,

+ true, // favicon

jam 2013/03/20 02:44:42 ditto

+ 0,

+ base::Bind(

+ &IconHelper::DownloadFaviconCallback, base::Unretained(this)));

break;

case content::FaviconURL::TOUCH_ICON:

if (listener_)