Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 129443002: Revert of For comparison, add std::vector. (Closed)

Created:
6 years, 11 months ago by mtklein
Modified:
6 years, 11 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of https://codereview.chromium.org/127223004/ Reason for revert: VS can't comprehend std::vector without exceptions. TBR=bsalomon@google.com,caryclark@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: http://code.google.com/p/skia/source/detail?r=12975

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -41 lines) Patch
M bench/StackBench.cpp View 6 chunks +0 lines, -41 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of For comparison, add std::vector.
6 years, 11 months ago (2014-01-08 21:31:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/129443002/1
6 years, 11 months ago (2014-01-08 21:31:06 UTC) #2
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 21:31:14 UTC) #3
Message was sent while issue was closed. 
Change committed as 12975

Powered by Google App Engine
This is Rietveld 408576698