Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: ui/base/clipboard/clipboard_android.cc

Issue 1294333002: Fix wrong usages of ScopedJavaLocalRef::Release(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment to Release() explaining it should not be used to call java methods Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/browser/shell_android.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/clipboard/clipboard_android.cc
diff --git a/ui/base/clipboard/clipboard_android.cc b/ui/base/clipboard/clipboard_android.cc
index b9298b482732ab962259c9e0a3d3a53d8f3994aa..8c77a9a78332529282586e5cefdfa43866e927df 100644
--- a/ui/base/clipboard/clipboard_android.cc
+++ b/ui/base/clipboard/clipboard_android.cc
@@ -71,10 +71,8 @@ ClipboardMap::ClipboardMap() {
jobject context = base::android::GetApplicationContext();
DCHECK(context);
- ScopedJavaLocalRef<jobject> local_ref =
- Java_Clipboard_create(env, context);
- DCHECK(local_ref.obj());
- clipboard_manager_.Reset(env, local_ref.Release());
+ clipboard_manager_.Reset(Java_Clipboard_create(env, context));
+ DCHECK(clipboard_manager_.obj());
}
std::string ClipboardMap::Get(const std::string& format) {
« no previous file with comments | « content/shell/browser/shell_android.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698