content/shell/browser/shell_android.cc - Issue 1294333002: Fix wrong usages of ScopedJavaLocalRef::Release().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_android.cc

Issue 1294333002: Fix wrong usages of ScopedJavaLocalRef::Release(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment to Release() explaining it should not be used to call java methods Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/browser/shell_android.cc

diff --git a/content/shell/browser/shell_android.cc b/content/shell/browser/shell_android.cc

index 85e4079428dc78edc9b759b6d42d37e60571239a..6139c8d25b900059231eabef929ad5d12f69530e 100644

--- a/content/shell/browser/shell_android.cc

+++ b/content/shell/browser/shell_android.cc

@@ -53,7 +53,7 @@ void Shell::PlatformSetIsLoading(bool loading) {

}

void Shell::PlatformCreateWindow(int width, int height) {

- java_object_.Reset(AttachCurrentThread(), CreateShellView(this));

+ java_object_.Reset(CreateShellView(this));

}

void Shell::PlatformSetContents() {

« no previous file with comments | « content/shell/android/shell_manager.cc ('k') | ui/base/clipboard/clipboard_android.cc » ('j') | no next file with comments »