Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Unified Diff: components/gcm_driver/gcm_driver_android.cc

Issue 1294333002: Fix wrong usages of ScopedJavaLocalRef::Release(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment to Release() explaining it should not be used to call java methods Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_driver_android.cc
diff --git a/components/gcm_driver/gcm_driver_android.cc b/components/gcm_driver/gcm_driver_android.cc
index f88bdd597f9f47d95b889bcc8c42a5da36545fb9..84a89982c687c2cffbcab40d701f8439727dbd36 100644
--- a/components/gcm_driver/gcm_driver_android.cc
+++ b/components/gcm_driver/gcm_driver_android.cc
@@ -196,10 +196,9 @@ void GCMDriverAndroid::RegisterImpl(
const std::string& app_id, const std::vector<std::string>& sender_ids) {
DCHECK_EQ(1u, sender_ids.size());
JNIEnv* env = AttachCurrentThread();
- Java_GCMDriver_register(
- env, java_ref_.obj(),
- ConvertUTF8ToJavaString(env, app_id).Release(),
- ConvertUTF8ToJavaString(env, sender_ids[0]).Release());
+ Java_GCMDriver_register(env, java_ref_.obj(),
+ ConvertUTF8ToJavaString(env, app_id).obj(),
+ ConvertUTF8ToJavaString(env, sender_ids[0]).obj());
}
void GCMDriverAndroid::UnregisterImpl(const std::string& app_id) {
@@ -209,10 +208,9 @@ void GCMDriverAndroid::UnregisterImpl(const std::string& app_id) {
void GCMDriverAndroid::UnregisterWithSenderIdImpl(
const std::string& app_id, const std::string& sender_id) {
JNIEnv* env = AttachCurrentThread();
- Java_GCMDriver_unregister(
- env, java_ref_.obj(),
- ConvertUTF8ToJavaString(env, app_id).Release(),
- ConvertUTF8ToJavaString(env, sender_id).Release());
+ Java_GCMDriver_unregister(env, java_ref_.obj(),
+ ConvertUTF8ToJavaString(env, app_id).obj(),
+ ConvertUTF8ToJavaString(env, sender_id).obj());
}
void GCMDriverAndroid::SendImpl(const std::string& app_id,

Powered by Google App Engine
This is Rietveld 408576698