add SkBitmap::installPixelRef()

add SkBitmap::installPixelRef()

BUG=
R=scroggo@google.com

Committed: https://code.google.com/p/skia/source/detail?r=13055

[reed1, 2014-01-08 22:48:25]

sort of close to ready ...

[scroggo, 2014-01-09 00:02:10]

https://codereview.chromium.org/129423002/diff/60001/include/core/SkImageInfo.h
File include/core/SkImageInfo.h (right):

https://codereview.chromium.org/129423002/diff/60001/include/core/SkImageInfo...
include/core/SkImageInfo.h:130: static SkImageInfo MakePMPremul(int width, int
height) {
Not a big fan of this name... Any chance we can change kPMColor_SkColorType to
something else, since it no longer means premul? Or maybe we just need to retcon
PM to something else?

https://codereview.chromium.org/129423002/diff/60001/src/core/SkBitmap.cpp
File src/core/SkBitmap.cpp (right):

https://codereview.chromium.org/129423002/diff/60001/src/core/SkBitmap.cpp#ne...
src/core/SkBitmap.cpp:358: return this->setPixelRef(pr);
This will overwrite fPixelRefOrigin. Instead, I think you should remove line 354
and change this to

return this->setPixelRef(pr, bounds.left(), bounds.top());

[hal.canary, 2014-01-09 13:46:56]

https://codereview.chromium.org/129423002/diff/60001/src/lazy/SkDiscardablePi...
File src/lazy/SkDiscardablePixelRef.cpp (right):

https://codereview.chromium.org/129423002/diff/60001/src/lazy/SkDiscardablePi...
src/lazy/SkDiscardablePixelRef.cpp:87: || (!dst->setConfig(info, 0))) {
Do we need dst->setConfig anymore?

Will it ever return false anymore?

[reed1, 2014-01-13 16:27:25]

https://codereview.chromium.org/129423002/diff/60001/include/core/SkImageInfo.h
File include/core/SkImageInfo.h (right):

https://codereview.chromium.org/129423002/diff/60001/include/core/SkImageInfo...
include/core/SkImageInfo.h:130: static SkImageInfo MakePMPremul(int width, int
height) {
On 2014/01/09 00:02:11, scroggo wrote:
> Not a big fan of this name... Any chance we can change kPMColor_SkColorType to
> something else, since it no longer means premul? Or maybe we just need to
retcon
> PM to something else?

Suggestions?

kNativeARGB32_ColorType?

https://codereview.chromium.org/129423002/diff/60001/src/core/SkBitmap.cpp
File src/core/SkBitmap.cpp (right):

https://codereview.chromium.org/129423002/diff/60001/src/core/SkBitmap.cpp#ne...
src/core/SkBitmap.cpp:358: return this->setPixelRef(pr);
On 2014/01/09 00:02:11, scroggo wrote:
> This will overwrite fPixelRefOrigin. Instead, I think you should remove line
354
> and change this to
> 
> return this->setPixelRef(pr, bounds.left(), bounds.top());

Done.

[scroggo, 2014-01-13 16:47:30]

On 2014/01/13 16:27:25, reed1 wrote:
>
https://codereview.chromium.org/129423002/diff/60001/include/core/SkImageInfo.h
> File include/core/SkImageInfo.h (right):
> 
>
https://codereview.chromium.org/129423002/diff/60001/include/core/SkImageInfo...
> include/core/SkImageInfo.h:130: static SkImageInfo MakePMPremul(int width, int
> height) {
> On 2014/01/09 00:02:11, scroggo wrote:
> > Not a big fan of this name... Any chance we can change kPMColor_SkColorType
to
> > something else, since it no longer means premul? Or maybe we just need to
> retcon
> > PM to something else?
> 
> Suggestions?
> 
> kNativeARGB32_ColorType?
> 
> https://codereview.chromium.org/129423002/diff/60001/src/core/SkBitmap.cpp
> File src/core/SkBitmap.cpp (right):
> 
>
https://codereview.chromium.org/129423002/diff/60001/src/core/SkBitmap.cpp#ne...
> src/core/SkBitmap.cpp:358: return this->setPixelRef(pr);
> On 2014/01/09 00:02:11, scroggo wrote:
> > This will overwrite fPixelRefOrigin. Instead, I think you should remove line
> 354
> > and change this to
> > 
> > return this->setPixelRef(pr, bounds.left(), bounds.top());
> 
> Done.

lgtm

[scroggo, 2014-01-13 17:48:48]

https://codereview.chromium.org/129423002/diff/60001/include/core/SkImageInfo.h
File include/core/SkImageInfo.h (right):

https://codereview.chromium.org/129423002/diff/60001/include/core/SkImageInfo...
include/core/SkImageInfo.h:130: static SkImageInfo MakePMPremul(int width, int
height) {
On 2014/01/13 16:27:26, reed1 wrote:
> On 2014/01/09 00:02:11, scroggo wrote:
> > Not a big fan of this name... Any chance we can change kPMColor_SkColorType
to
> > something else, since it no longer means premul? Or maybe we just need to
> retcon
> > PM to something else?
> 
> Suggestions?
> 
> kNativeARGB32_ColorType?

sgtm

[reed1, 2014-01-13 20:18:09]

Committed patchset #5 manually as r13055 (presubmit successful).

[reed1, 2014-01-13 20:23:31]

A revert of this CL has been created in
https://codereview.chromium.org/137133003/ by reed@google.com.

The reason for reverting is: broke tests (compile).

[epoger, 2014-01-13 21:29:31]

On 2014/01/13 20:23:31, reed1 wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/137133003/ by mailto:reed@google.com.
> 
> The reason for reverting is: broke tests (compile).

Please consider committing via the commit queue.  It won't catch all build
failures, but it will catch some of them.

As an added bonus, you can use a pure git checkout when using the commit queue! 
See
https://sites.google.com/site/skiadocs/developer-documentation/contributing-c...
for updated step-by-step directions.