DevTools: Tweak id calculation for JSFrames

DevTools: Tweak id calculation for JSFrames

There are frames that should be merged together, but they are not
because some of them contain callUID (those coming from CPU profiler)
and those that don't contain it (those coming from trace event stacks).

Do not use callUID in the frame id calculation.

BUG=521473
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200751

[alph, 2015-08-17 19:12:50]

alph@chromium.org changed reviewers:
+ yurys@chromium.org

[yurys, 2015-08-17 19:21:36]

lgtm,

let's get rid of callUID and do all the CodeEntry matching on the front-end?

https://codereview.chromium.org/1294183002/diff/1/Source/devtools/front_end/t...
File Source/devtools/front_end/timeline/TimelineTreeView.js (right):

https://codereview.chromium.org/1294183002/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineTreeView.js:273: return "f:" +
data["functionName"] + "@" + (data["scriptId"] || data["url"] || "");
Can we have a test for this?

[alph, 2015-08-17 21:09:34]

ptal

https://codereview.chromium.org/1294183002/diff/1/Source/devtools/front_end/t...
File Source/devtools/front_end/timeline/TimelineTreeView.js (right):

https://codereview.chromium.org/1294183002/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineTreeView.js:273: return "f:" +
data["functionName"] + "@" + (data["scriptId"] || data["url"] || "");
On 2015/08/17 19:21:36, yurys wrote:
> Can we have a test for this?
> 

Done.

[yurys, 2015-08-17 21:28:16]

lgtm, thanks!

[alph, 2015-08-18 06:33:06]

The CQ bit was checked by alph@chromium.org

[alph, 2015-08-18 06:33:06]

The patchset sent to the CQ was uploaded after l-g-t-m from yurys@chromium.org
Link to the patchset: https://codereview.chromium.org/1294183002/#ps40001
(title: "rebaseline")

[commit-bot: I haz the power, 2015-08-18 06:33:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1294183002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1294183002/40001

[commit-bot: I haz the power, 2015-08-18 07:26:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 07:26:12]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alph, 2015-08-18 18:05:33]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2015-08-18 18:05:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1294183002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1294183002/40001

[commit-bot: I haz the power, 2015-08-18 20:16:00]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200751