Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: LayoutTests/inspector/tracing/timeline-js-callstacks.html

Issue 1294183002: DevTools: Tweak id calculation for JSFrames (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebaseline Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/inspector/tracing/timeline-js-callstacks-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/inspector/tracing/timeline-js-callstacks.html
diff --git a/LayoutTests/inspector/tracing/timeline-js-callstacks.html b/LayoutTests/inspector/tracing/timeline-js-callstacks.html
index 4559d41fb902f9b3e5a3fc705a3372b37468017d..f20da5f759de8bfbffc093dccc198a2287264f32 100644
--- a/LayoutTests/inspector/tracing/timeline-js-callstacks.html
+++ b/LayoutTests/inspector/tracing/timeline-js-callstacks.html
@@ -362,6 +362,56 @@ function test()
"ts": 251100,
},
{
+ "args": {
+ "data": {
+ "stackTrace": [
+ { "functionName": "w", "scriptId": 1 },
+ { "functionName": "y", "callUID": "y", "scriptId": 1 },
+ { "functionName": "x", "callUID": "x", "scriptId": 1 }
+ ]
+ }
+ },
+ "cat": "disabled-by-default-devtools.timeline",
+ "name": "JSSample",
+ "ph": "I",
+ "pid": 17851,
+ "tid": 23,
+ "ts": 251200,
+ },
+ {
+ "args": {
+ "data": {
+ "stackTrace": [
+ { "functionName": "w", "scriptId": 1 },
+ { "functionName": "y", "callUID": "y", "scriptId": 1 },
+ { "functionName": "x", "callUID": "x", "scriptId": 1 }
+ ]
+ }
+ },
+ "cat": "disabled-by-default-devtools.timeline",
+ "name": "JSSample",
+ "ph": "I",
+ "pid": 17851,
+ "tid": 23,
+ "ts": 251300,
+ },
+ {
+ "args": {
+ "data": {
+ "stackTrace": [
+ { "functionName": "y", "callUID": "y", "scriptId": 1 },
+ { "functionName": "x", "callUID": "x", "scriptId": 1 }
+ ]
+ }
+ },
+ "cat": "disabled-by-default-devtools.timeline",
+ "name": "JSSample",
+ "ph": "I",
+ "pid": 17851,
+ "tid": 23,
+ "ts": 251400,
+ },
+ {
"args": {},
"cat": "disabled-by-default-devtools.timeline",
"name": "Program",
@@ -387,17 +437,11 @@ function test()
WebInspector.TimelineUIUtils.hiddenEventsFilter(),
new WebInspector.ExcludeTopLevelFilter()
];
- var treeTopDown = WebInspector.TimelineModel.buildTopDownTree(events, 0, Infinity, filters, eventId);
+ var treeTopDown = WebInspector.TimelineModel.buildTopDownTree(events, 0, Infinity, filters, WebInspector.TimelineTreeView.eventId);
printProfileTree(0, treeTopDown);
var treeBottomUp = WebInspector.TimelineModel.buildBottomUpTree(treeTopDown);
printProfileTree(0, treeBottomUp);
- function eventId(event)
- {
- var data = event.args.data;
- return data && (data.callUID || data.functionNode);
- }
-
function printProfileTree(padding, node)
{
InspectorTest.addResult(" ".repeat(padding) + node.name + ": " + [node.selfTime, node.totalTime].map(function (t) { return t.toFixed(3); }).join(" "));
« no previous file with comments | « no previous file | LayoutTests/inspector/tracing/timeline-js-callstacks-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698