Issue 129413003: Use NSSRWLock instead of PRRWLock in sslSessionID. This avoids the bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 129413003: Use NSSRWLock instead of PRRWLock in sslSessionID. This avoids the bugs (Closed)

Created:
6 years, 11 months ago by wtc

Modified:
6 years, 11 months ago

Reviewers:
Lei Zhang, agl

CC:
chromium-reviews, cbentzel+watch_chromium.org, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org, Nico

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Use NSSRWLock instead of PRRWLock in sslSessionID. This avoids the bugs in the lock rank checking code in PRRWLock. Remove the suppression for the memory leak in _PR_SET_THREAD_RWLOCK_RANK. R=agl@chromium.org,thestig@chromium.org BUG=124445, 331625 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243875

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+268 lines, -36 lines)			Patch
M	net/third_party/nss/README.chromium	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	net/third_party/nss/patches/applypatches.sh	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	net/third_party/nss/patches/nssrwlock.patch	View	1 chunk	+235 lines, -0 lines	0 comments	Download
M	net/third_party/nss/ssl/ssl3con.c	View	15 chunks	+21 lines, -21 lines	0 comments	Download
M	net/third_party/nss/ssl/sslimpl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/third_party/nss/ssl/sslnonce.c	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1 chunk	+0 lines, -10 lines	0 comments	Download

Total messages: 5 (0 generated)

Lei Zhang

tools/valgrind/memcheck/suppressions.txt lgtm thakis is the current memory sheriff and he can verify, assuming this CL ...

6 years, 11 months ago (2014-01-08 23:44:59 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/129413003/1

6 years, 11 months ago (2014-01-09 01:40:33 UTC) #4

Message was sent while issue was closed.

Change committed as 243875