Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: net/third_party/nss/ssl/sslimpl.h

Issue 129413003: Use NSSRWLock instead of PRRWLock in sslSessionID. This avoids the bugs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/third_party/nss/ssl/ssl3con.c ('k') | net/third_party/nss/ssl/sslnonce.c » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is PRIVATE to SSL and should be the first thing included by 2 * This file is PRIVATE to SSL and should be the first thing included by
3 * any SSL implementation file. 3 * any SSL implementation file.
4 * 4 *
5 * This Source Code Form is subject to the terms of the Mozilla Public 5 * This Source Code Form is subject to the terms of the Mozilla Public
6 * License, v. 2.0. If a copy of the MPL was not distributed with this 6 * License, v. 2.0. If a copy of the MPL was not distributed with this
7 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ 7 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
8 8
9 #ifndef __sslimpl_h_ 9 #ifndef __sslimpl_h_
10 #define __sslimpl_h_ 10 #define __sslimpl_h_
(...skipping 710 matching lines...) Expand 10 before | Expand all | Expand 10 after
721 721
722 /* Signed certificate timestamps received in a TLS extension. 722 /* Signed certificate timestamps received in a TLS extension.
723 ** (used only in client). 723 ** (used only in client).
724 */ 724 */
725 SECItem signedCertTimestamps; 725 SECItem signedCertTimestamps;
726 726
727 /* This lock is lazily initialized by CacheSID when a sid is first 727 /* This lock is lazily initialized by CacheSID when a sid is first
728 * cached. Before then, there is no need to lock anything because 728 * cached. Before then, there is no need to lock anything because
729 * the sid isn't being shared by anything. 729 * the sid isn't being shared by anything.
730 */ 730 */
731 » PRRWLock *lock; 731 » NSSRWLock *lock;
732 732
733 /* The lock must be held while reading or writing these members 733 /* The lock must be held while reading or writing these members
734 * because they change while the sid is cached. 734 * because they change while the sid is cached.
735 */ 735 */
736 struct { 736 struct {
737 /* The session ticket, if we have one, is sent as an extension 737 /* The session ticket, if we have one, is sent as an extension
738 * in the ClientHello message. This field is used only by 738 * in the ClientHello message. This field is used only by
739 * clients. It is protected by lock when lock is non-null 739 * clients. It is protected by lock when lock is non-null
740 * (after the sid has been added to the client session cache). 740 * (after the sid has been added to the client session cache).
741 */ 741 */
(...skipping 1284 matching lines...) Expand 10 before | Expand all | Expand 10 after
2026 #if defined(XP_UNIX) || defined(XP_OS2) || defined(XP_BEOS) 2026 #if defined(XP_UNIX) || defined(XP_OS2) || defined(XP_BEOS)
2027 #define SSL_GETPID getpid 2027 #define SSL_GETPID getpid
2028 #elif defined(WIN32) 2028 #elif defined(WIN32)
2029 extern int __cdecl _getpid(void); 2029 extern int __cdecl _getpid(void);
2030 #define SSL_GETPID _getpid 2030 #define SSL_GETPID _getpid
2031 #else 2031 #else
2032 #define SSL_GETPID() 0 2032 #define SSL_GETPID() 0
2033 #endif 2033 #endif
2034 2034
2035 #endif /* __sslimpl_h_ */ 2035 #endif /* __sslimpl_h_ */
OLDNEW
« no previous file with comments | « net/third_party/nss/ssl/ssl3con.c ('k') | net/third_party/nss/ssl/sslnonce.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698