Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1294093003: [heap] Unify MarkingDeque push and unshift operations. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-heap-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Unify MarkingDeque push and unshift operations. R=hpayer@chromium.org Committed: https://crrev.com/26241740bbbd5990eb940154c53ab85f0c5628cc Cr-Commit-Position: refs/heads/master@{#30202}

Patch Set 1 #

Patch Set 2 : Fix test case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -31 lines) Patch
M src/heap/incremental-marking.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/incremental-marking-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/mark-compact.h View 3 chunks +6 lines, -25 lines 0 comments Download
M src/heap/mark-compact-inl.h View 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1293773002 Patch 40001

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-17 10:40:39 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 4 months ago (2015-08-17 15:02:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294093003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294093003/20001
5 years, 4 months ago (2015-08-17 15:59:33 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-17 16:58:22 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 16:58:35 UTC) #6
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/26241740bbbd5990eb940154c53ab85f0c5628cc
Cr-Commit-Position: refs/heads/master@{#30202}

Powered by Google App Engine
This is Rietveld 408576698