[heap] Simplify MarkingDeque implementation.

[heap] Simplify MarkingDeque implementation.

This removes the dependency of the MarkingDeque on the underlying
collector by moving out the live bytes accounting and object color
mutations into a wrapper. The MarkingDeque can now be split into a
separate file.

R=hpayer@chromium.org

Committed: https://crrev.com/33922309919bf9a0aa9989b34560b3d60bcf9b82
Cr-Commit-Position: refs/heads/master@{#30194}

[Michael Starzinger, 2015-08-14 12:06:24]

mstarzinger@chromium.org changed reviewers:
+ hpayer@chromium.org, mlippautz@chromium.org

[Michael Starzinger, 2015-08-14 12:06:24]

mstarzinger@chromium.org changed required reviewers:
+ hpayer@chromium.org

[Michael Starzinger, 2015-08-14 12:08:24]

Hannes: PTAL.
Mike: FYI.

https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):

https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact.h...
src/heap/mark-compact.h:210: INLINE(bool PushBlack(HeapObject* object)) {
Note that {PushBlack} and {PushGrey} can now be unified into one single {Push}
method. Let me know if you want me to do that in this CL or in a separate CL.

https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact.h...
src/heap/mark-compact.h:240: INLINE(void UnshiftGrey(HeapObject* object)) {
Likewise for unification of {UnshiftGrey} and {UnshiftBlack}.

[Michael Lippautz, 2015-08-14 12:44:36]

lgtm, I like it. Let's wait for Hannes.

https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact-i...
File src/heap/mark-compact-inl.h (right):

https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact-i...
src/heap/mark-compact-inl.h:26: void MarkCompactCollector::PushBlack(HeapObject*
obj) {
Suggestion: We could return the status of the operation here, turning most
callers of this function into
  if (!PushBlack(object)) return;

[Hannes Payer (out of office), 2015-08-14 13:09:14]

On 2015/08/14 12:44:36, Michael Lippautz wrote:
> lgtm, I like it. Let's wait for Hannes.
> 
>
https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact-i...
> File src/heap/mark-compact-inl.h (right):
> 
>
https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact-i...
> src/heap/mark-compact-inl.h:26: void
MarkCompactCollector::PushBlack(HeapObject*
> obj) {
> Suggestion: We could return the status of the operation here, turning most
> callers of this function into
>   if (!PushBlack(object)) return;

We could also wrap the unshift sites. Wdyt?

[Michael Starzinger, 2015-08-14 13:22:21]

On 2015/08/14 13:09:14, Hannes Payer wrote:
> On 2015/08/14 12:44:36, Michael Lippautz wrote:
> > lgtm, I like it. Let's wait for Hannes.
> > 
> >
>
https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact-i...
> > File src/heap/mark-compact-inl.h (right):
> > 
> >
>
https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact-i...
> > src/heap/mark-compact-inl.h:26: void
> MarkCompactCollector::PushBlack(HeapObject*
> > obj) {
> > Suggestion: We could return the status of the operation here, turning most
> > callers of this function into
> >   if (!PushBlack(object)) return;
> 
> We could also wrap the unshift sites. Wdyt?

I started out with wrapping UnshiftBlack as well, but it would need to be called
from IncrementalMarkingMarkingVisitor which is not a fried of
MarkCompactCollector. And making that wrapper public rubs me the wrong way. Let
me know if you still want me to wrap it and make those two classes friends.

[Michael Starzinger, 2015-08-14 13:23:13]

https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact-i...
File src/heap/mark-compact-inl.h (right):

https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact-i...
src/heap/mark-compact-inl.h:26: void MarkCompactCollector::PushBlack(HeapObject*
obj) {
On 2015/08/14 12:44:36, Michael Lippautz wrote:
> Suggestion: We could return the status of the operation here, turning most
> callers of this function into
>   if (!PushBlack(object)) return;

Acknowledged. Would you be fine with doing this as a follow-up?

[Michael Lippautz, 2015-08-14 13:26:46]

https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact-i...
File src/heap/mark-compact-inl.h (right):

https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact-i...
src/heap/mark-compact-inl.h:26: void MarkCompactCollector::PushBlack(HeapObject*
obj) {
On 2015/08/14 13:23:13, Michael Starzinger wrote:
> On 2015/08/14 12:44:36, Michael Lippautz wrote:
> > Suggestion: We could return the status of the operation here, turning most
> > callers of this function into
> >   if (!PushBlack(object)) return;
> 
> Acknowledged. Would you be fine with doing this as a follow-up?

Sure.

[Hannes Payer (out of office), 2015-08-17 09:39:10]

https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):

https://codereview.chromium.org/1293773002/diff/20001/src/heap/mark-compact.h...
src/heap/mark-compact.h:210: INLINE(bool PushBlack(HeapObject* object)) {
On 2015/08/14 12:08:23, Michael Starzinger wrote:
> Note that {PushBlack} and {PushGrey} can now be unified into one single {Push}
> method. Let me know if you want me to do that in this CL or in a separate CL.

I like it, you can do it in a separate cl.

[Michael Starzinger, 2015-08-17 10:42:10]

Addressed offline comment. PTAL.

[Hannes Payer (out of office), 2015-08-17 12:37:00]

lgtm

https://codereview.chromium.org/1293773002/diff/40001/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):

https://codereview.chromium.org/1293773002/diff/40001/src/heap/mark-compact.h...
src/heap/mark-compact.h:765: friend class MarkCompactMarkingVisitor;
Since you are here... can we sort them?

[Michael Starzinger, 2015-08-17 12:44:10]

Addressed comment. Rebased. Landing.

https://codereview.chromium.org/1293773002/diff/40001/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):

https://codereview.chromium.org/1293773002/diff/40001/src/heap/mark-compact.h...
src/heap/mark-compact.h:765: friend class MarkCompactMarkingVisitor;
On 2015/08/17 12:36:59, Hannes Payer wrote:
> Since you are here... can we sort them?

Done.

[Michael Starzinger, 2015-08-17 12:50:50]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2015-08-17 12:50:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org, hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1293773002/#ps80001
(title: "Rebased.")

[commit-bot: I haz the power, 2015-08-17 12:50:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1293773002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1293773002/80001

[commit-bot: I haz the power, 2015-08-17 13:09:34]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-08-17 13:09:48]

Patchset 5 (id:??) landed as
https://crrev.com/33922309919bf9a0aa9989b34560b3d60bcf9b82
Cr-Commit-Position: refs/heads/master@{#30194}