Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1294003002: clang/win: Enable -Wswitch. (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Enable -Wswitch. BUG=505308 Committed: https://crrev.com/40b3bd7de9e9f7425b24bc5d8e6e888e9dde6af6 Cr-Commit-Position: refs/heads/master@{#343736}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : ... #

Patch Set 4 : for real #

Patch Set 5 : msvc #

Patch Set 6 : gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M build/common.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/profiles/file_path_verifier_win.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/speech/tts_win.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/npapi/webplugin_delegate_impl_win.cc View 1 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Nico
5 years, 4 months ago (2015-08-17 16:00:09 UTC) #2
dcheng
What about GN?
5 years, 4 months ago (2015-08-17 16:19:43 UTC) #3
Nico
good catch. done, thanks
5 years, 4 months ago (2015-08-17 16:46:23 UTC) #4
dcheng
lgtm
5 years, 4 months ago (2015-08-17 16:48:04 UTC) #5
Nico
+avi for content/OWNERS
5 years, 4 months ago (2015-08-17 16:48:38 UTC) #7
Avi (use Gerrit)
lgtm 🎉
5 years, 4 months ago (2015-08-17 18:14:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294003002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294003002/100001
5 years, 4 months ago (2015-08-17 18:16:04 UTC) #10
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 4 months ago (2015-08-17 19:34:48 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 19:35:33 UTC) #12
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/40b3bd7de9e9f7425b24bc5d8e6e888e9dde6af6
Cr-Commit-Position: refs/heads/master@{#343736}

Powered by Google App Engine
This is Rietveld 408576698