build/config/compiler/BUILD.gn - Issue 1294003002: clang/win: Enable -Wswitch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 1294003002: clang/win: Enable -Wswitch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gn Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index 80b13e6701dea860bb18cb0ee9a3dd1a907b7692..7a00b9384cf9ad756b5e3bcb9a55cfdfbb6b5898 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -859,7 +859,6 @@ if (is_win) {

# TODO(hans): Make this list shorter eventually, http://crbug.com/504657

"-Qunused-arguments", # http://crbug.com/504658

"-Wno-microsoft", # http://crbug.com/505296

- "-Wno-switch", # http://crbug.com/505308

"-Wno-unknown-pragmas", # http://crbug.com/505314

"-Wno-unused-value", # http://crbug.com/505318

]

« no previous file with comments | « build/common.gypi ('k') | chrome/browser/metrics/chrome_metrics_service_client.cc » ('j') | no next file with comments »