Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h - Issue 1293953003: Fix flaky crash in WebPagePopupImpl::closePopup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h

Issue 1293953003: Fix flaky crash in WebPagePopupImpl::closePopup. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h

diff --git a/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h b/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h

index 8c24696fc5feaee2fe4f640d06bb1b5c856d73cd..7273906875008beb06586a41b296a6cbb9a6df0b 100644

--- a/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h

+++ b/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h

@@ -95,6 +95,7 @@ private:

// InputType functions

String badInputText() const override;

void blur() final;

+ void closePopupView() override;

PassRefPtr<ComputedStyle> customStyleForLayoutObject(PassRefPtr<ComputedStyle>) override;

void createShadowSubtree() final;

void destroyShadowSubtree() final;