Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp - Issue 1293953003: Fix flaky crash in WebPagePopupImpl::closePopup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

Issue 1293953003: Fix flaky crash in WebPagePopupImpl::closePopup. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

diff --git a/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp b/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

index e5c1d7bc8d16552154840a84ca263c1e09588b04..a9b9736ebde606906117d7964baf111f19e93395 100644

--- a/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

+++ b/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp

@@ -539,6 +539,12 @@ void BaseMultipleFieldsDateAndTimeInputType::updateView()

updateClearButtonVisibility();

}

+void BaseMultipleFieldsDateAndTimeInputType::closePopupView()

+ if (PickerIndicatorElement* picker = pickerIndicatorElement())

+ picker->closePopup();

void BaseMultipleFieldsDateAndTimeInputType::valueAttributeChanged()

{

if (!element().hasDirtyValue())