Devtools: Create a separate mode to turn LayoutEditor on

Devtools: Create a separate mode to turn LayoutEditor on

BUG=501896
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200872

[sergeyv, 2015-08-18 23:32:15]

sergeyv@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[pfeldman, 2015-08-18 23:48:02]

Please extract the part that increases the sprite size. Also, each sprite icon
should fit 16x16 inside the 32x24 box.

[sergeyv, 2015-08-19 02:23:19]

On 2015/08/18 23:48:02, pfeldman wrote:
> Please extract the part that increases the sprite size. Also, each sprite icon
> should fit 16x16 inside the 32x24 box.

Done.

[sergeyv, 2015-08-19 22:05:12]

@dgozman, please take a look

[dgozman, 2015-08-19 22:49:43]

lgtm

https://codereview.chromium.org/1293793008/diff/40001/Source/devtools/front_e...
File Source/devtools/front_end/elements/ElementsPanel.js (right):

https://codereview.chromium.org/1293793008/diff/40001/Source/devtools/front_e...
Source/devtools/front_end/elements/ElementsPanel.js:139: if
(Runtime.experiments.isEnabled("layoutEditor")) {
&& !Runtime.queryParam("remoteFrontend")

https://codereview.chromium.org/1293793008/diff/40001/Source/devtools/front_e...
Source/devtools/front_end/elements/ElementsPanel.js:140:
this._layoutEditorButton = new
WebInspector.ToolbarButton(WebInspector.UIString("Turn on Layout Editor"),
"layout-editor");
Toggle Layout Editor

https://codereview.chromium.org/1293793008/diff/40001/Source/devtools/front_e...
Source/devtools/front_end/elements/ElementsPanel.js:1113: if
(WebInspector.inspectElementModeController &&
WebInspector.inspectElementModeController.enabled())
Let's add a comment.

https://codereview.chromium.org/1293793008/diff/40001/Source/devtools/front_e...
Source/devtools/front_end/elements/ElementsPanel.js:1114:
domModel.setInspectModeEnabled(true,
WebInspector.moduleSetting("showUAShadowDOM").get())
nit: semicolon missing

https://codereview.chromium.org/1293793008/diff/40001/Source/devtools/front_e...
Source/devtools/front_end/elements/ElementsPanel.js:1326:
WebInspector.DefaultDOMNodeHighlighter.prototype.highlightDOMNode.call(this,
selectedNode, config)
nit: semicolon missing

[sergeyv, 2015-08-19 23:36:42]

https://codereview.chromium.org/1293793008/diff/40001/Source/devtools/front_e...
File Source/devtools/front_end/elements/ElementsPanel.js (right):

https://codereview.chromium.org/1293793008/diff/40001/Source/devtools/front_e...
Source/devtools/front_end/elements/ElementsPanel.js:139: if
(Runtime.experiments.isEnabled("layoutEditor")) {
On 2015/08/19 22:49:43, dgozman wrote:
> && !Runtime.queryParam("remoteFrontend")

Done.

https://codereview.chromium.org/1293793008/diff/40001/Source/devtools/front_e...
Source/devtools/front_end/elements/ElementsPanel.js:140:
this._layoutEditorButton = new
WebInspector.ToolbarButton(WebInspector.UIString("Turn on Layout Editor"),
"layout-editor");
On 2015/08/19 22:49:43, dgozman wrote:
> Toggle Layout Editor

Done.

https://codereview.chromium.org/1293793008/diff/40001/Source/devtools/front_e...
Source/devtools/front_end/elements/ElementsPanel.js:1113: if
(WebInspector.inspectElementModeController &&
WebInspector.inspectElementModeController.enabled())
On 2015/08/19 22:49:43, dgozman wrote:
> Let's add a comment.

Done.

https://codereview.chromium.org/1293793008/diff/40001/Source/devtools/front_e...
Source/devtools/front_end/elements/ElementsPanel.js:1114:
domModel.setInspectModeEnabled(true,
WebInspector.moduleSetting("showUAShadowDOM").get())
On 2015/08/19 22:49:43, dgozman wrote:
> nit: semicolon missing

Done.

https://codereview.chromium.org/1293793008/diff/40001/Source/devtools/front_e...
Source/devtools/front_end/elements/ElementsPanel.js:1326:
WebInspector.DefaultDOMNodeHighlighter.prototype.highlightDOMNode.call(this,
selectedNode, config)
On 2015/08/19 22:49:43, dgozman wrote:
> nit: semicolon missing

Done.

[sergeyv, 2015-08-20 01:11:04]

The CQ bit was checked by sergeyv@chromium.org

[sergeyv, 2015-08-20 01:11:05]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1293793008/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2015-08-20 01:11:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1293793008/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1293793008/60001

[commit-bot: I haz the power, 2015-08-20 01:18:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-20 01:18:43]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pfeldman, 2015-08-20 01:19:50]

lgtm

[sergeyv, 2015-08-20 01:20:50]

The CQ bit was checked by sergeyv@chromium.org

[commit-bot: I haz the power, 2015-08-20 01:20:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1293793008/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1293793008/60001

[commit-bot: I haz the power, 2015-08-20 02:27:36]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200872