Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1290883006: Devtools: Add new row in toolbarButtonGlyphs and layout editor icon (Closed)

Created:
5 years, 4 months ago by sergeyv
Modified:
5 years, 4 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools: Add new row in toolbarButtonGlyphs and layout editor icon NOTRY=true BUG=501896 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200867

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -71 lines) Patch
M Source/devtools/front_end/Images/src/optimize_png.hashes View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/Images/src/svg2png.hashes View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/Images/src/toolbarButtonGlyphs.svg View 10 chunks +57 lines, -31 lines 0 comments Download
M Source/devtools/front_end/Images/toolbarButtonGlyphs.png View Binary file 0 comments Download
M Source/devtools/front_end/Images/toolbarButtonGlyphs_2x.png View Binary file 0 comments Download
M Source/devtools/front_end/audits/auditResultTree.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/components/breakpointsList.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/components/customPreviewSection.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/components/networkConditionsSettingsTab.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/console/consoleView.css View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/elements/computedStyleSidebarPane.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/elementsPanel.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/elementsTreeOutline.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/emulation/devicesSettingsTab.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/emulation/overrides.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/inspectorStyle.css View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/network/xmlView.css View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/profiler/profilesPanel.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/promises/promisePane.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/resources/resourcesPanel.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/resources/serviceWorkersView.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sidebarPane.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/sourcesSearch.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/timelinePanel.css View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/ui/checkboxTextLabel.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/closeButton.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/propertiesSection.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/section.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/smallIcon.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/softContextMenu.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/splitWidget.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/toolbar.css View 1 5 chunks +8 lines, -4 lines 0 comments Download
M Source/devtools/front_end/ui/treeoutline.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui_lazy/dataGrid.css View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
sergeyv
5 years, 4 months ago (2015-08-19 02:21:44 UTC) #3
sergeyv
5 years, 4 months ago (2015-08-19 02:21:45 UTC) #4
dgozman
lgtm https://codereview.chromium.org/1290883006/diff/1/Source/devtools/front_end/ui/toolbar.css File Source/devtools/front_end/ui/toolbar.css (right): https://codereview.chromium.org/1290883006/diff/1/Source/devtools/front_end/ui/toolbar.css#newcode527 Source/devtools/front_end/ui/toolbar.css:527: .layout-editor .glyph { .layout-editor-toolbar-item
5 years, 4 months ago (2015-08-19 18:49:34 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290883006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290883006/1
5 years, 4 months ago (2015-08-19 21:11:04 UTC) #7
sergeyv
https://codereview.chromium.org/1290883006/diff/1/Source/devtools/front_end/ui/toolbar.css File Source/devtools/front_end/ui/toolbar.css (right): https://codereview.chromium.org/1290883006/diff/1/Source/devtools/front_end/ui/toolbar.css#newcode527 Source/devtools/front_end/ui/toolbar.css:527: .layout-editor .glyph { On 2015/08/19 18:49:34, dgozman wrote: > ...
5 years, 4 months ago (2015-08-19 22:08:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290883006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290883006/20001
5 years, 4 months ago (2015-08-19 22:09:47 UTC) #11
commit-bot: I haz the power
Failed to apply patch for Source/devtools/front_end/network/xmlView.css: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 4 months ago (2015-08-20 00:02:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290883006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290883006/40001
5 years, 4 months ago (2015-08-20 00:55:13 UTC) #17
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 01:01:34 UTC) #18
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200867

Powered by Google App Engine
This is Rietveld 408576698