Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1293793007: Unprefix min-content, max-content, fit-content (Closed)

Created:
5 years, 4 months ago by cbiesinger
Modified:
5 years, 4 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Unprefix min-content, max-content, fit-content This does not yet unprefix fill-available (aka fill), because the CSSWG is not ready for that yet: https://lists.w3.org/Archives/Public/www-style/2015Aug/0127.html Intent to ship: https://groups.google.com/a/chromium.org/d/topic/blink-dev/2ljVa4n_ZX0/discussion BUG=245157 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200846

Patch Set 1 #

Patch Set 2 : add tests #

Patch Set 3 : unprefix more tests #

Total comments: 2

Patch Set 4 : review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -83 lines) Patch
M LayoutTests/fast/css-intrinsic-dimensions/css-tables.html View 1 7 chunks +11 lines, -11 lines 0 comments Download
M LayoutTests/fast/css-intrinsic-dimensions/height-property-value.html View 1 2 3 1 chunk +22 lines, -17 lines 0 comments Download
M LayoutTests/fast/css-intrinsic-dimensions/height-property-value-expected.txt View 1 2 chunks +30 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-intrinsic-dimensions/intrinsic-sized-absolutes.html View 1 2 3 chunks +12 lines, -12 lines 0 comments Download
M LayoutTests/fast/css-intrinsic-dimensions/intrinsic-sized-blocks.html View 1 2 3 chunks +12 lines, -12 lines 0 comments Download
M LayoutTests/fast/css-intrinsic-dimensions/intrinsic-sized-replaced-absolutes.html View 1 2 3 chunks +12 lines, -12 lines 0 comments Download
M LayoutTests/fast/css-intrinsic-dimensions/tables.html View 1 2 7 chunks +11 lines, -11 lines 0 comments Download
M LayoutTests/fast/css-intrinsic-dimensions/width-property-value.html View 1 2 3 2 chunks +7 lines, -4 lines 0 comments Download
M LayoutTests/fast/css-intrinsic-dimensions/width-property-value-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
cbiesinger
5 years, 4 months ago (2015-08-19 18:29:10 UTC) #2
leviw_travelin_and_unemployed
lgtm https://codereview.chromium.org/1293793007/diff/40001/LayoutTests/fast/css-intrinsic-dimensions/height-property-value.html File LayoutTests/fast/css-intrinsic-dimensions/height-property-value.html (right): https://codereview.chromium.org/1293793007/diff/40001/LayoutTests/fast/css-intrinsic-dimensions/height-property-value.html#newcode27 LayoutTests/fast/css-intrinsic-dimensions/height-property-value.html:27: var PREFIXED_KEYWORDS = ['min-content', 'max-content', 'fill-available', 'fit-content']; Do ...
5 years, 4 months ago (2015-08-19 18:38:00 UTC) #3
cbiesinger
https://codereview.chromium.org/1293793007/diff/40001/LayoutTests/fast/css-intrinsic-dimensions/height-property-value.html File LayoutTests/fast/css-intrinsic-dimensions/height-property-value.html (right): https://codereview.chromium.org/1293793007/diff/40001/LayoutTests/fast/css-intrinsic-dimensions/height-property-value.html#newcode27 LayoutTests/fast/css-intrinsic-dimensions/height-property-value.html:27: var PREFIXED_KEYWORDS = ['min-content', 'max-content', 'fill-available', 'fit-content']; On 2015/08/19 ...
5 years, 4 months ago (2015-08-19 18:41:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293793007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293793007/60001
5 years, 4 months ago (2015-08-19 18:45:54 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 20:43:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200846

Powered by Google App Engine
This is Rietveld 408576698