LayoutTests/fast/css-intrinsic-dimensions/height-property-value.html - Issue 1293793007: Unprefix min-content, max-content, fit-content

Side by Side Diff: LayoutTests/fast/css-intrinsic-dimensions/height-property-value.html

Issue 1293793007: Unprefix min-content, max-content, fit-content (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: unprefix more tests Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fast/css-intrinsic-dimensions/css-tables.html ('k') | LayoutTests/fast/css-intrinsic-dimensions/height-property-value-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <!--	2 <!--

3 Tests that the height keywords are not respected by the parser yet.	3 Tests that the height keywords are respected by the parser.

4 -->	4 -->

5 <script src="../../resources/js-test.js"></script>	5 <script src="../../resources/js-test.js"></script>

6	6

7 <div style="height: -webkit-min-content; min-height: -webkit-min-content; max-he ight: -webkit-min-content;" expected-data="min-content"></div>	7 <div style="height: -webkit-min-content; min-height: -webkit-min-content; max-he ight: -webkit-min-content;" expected-data="-webkit-min-content"></div>

8 <div style="height: -webkit-max-content; min-height: -webkit-max-content; max-he ight: -webkit-max-content;" expected-data="max-content"></div>	8 <div style="height: -webkit-max-content; min-height: -webkit-max-content; max-he ight: -webkit-max-content;" expected-data="-webkit-max-content"></div>

9 <div style="height: -webkit-fill-available; min-height: -webkit-fill-available; max-height: -webkit-fill-available;" expected-data="fill-available"></div>	9 <div style="height: -webkit-fill-available; min-height: -webkit-fill-available; max-height: -webkit-fill-available;" expected-data="-webkit-fill-available"></di v>

10 <div style="height: -webkit-fit-content; min-height: -webkit-fit-content; max-he ight: -webkit-fit-content;" expected-data="fit-content"></div>	10 <div style="height: -webkit-fit-content; min-height: -webkit-fit-content; max-he ight: -webkit-fit-content;" expected-data="-webkit-fit-content"></div>

	11

	12 <div style="height: min-content; min-height: min-content; max-height: min-conten t;" expected-data="min-content"></div>

	13 <div style="height: max-content; min-height: max-content; max-height: max-conten t;" expected-data="max-content"></div>

	14 <div style="height: fit-content; min-height: fit-content; max-height: fit-conten t;" expected-data="fit-content"></div>

11	15

12 <script>	16 <script>

13 description('Tests that the height keywords are parsed.');	17 description('Tests that the height keywords are parsed.');

14 var PREFIX = '-webkit-';	18 var PREFIX = '-webkit-';

15	19

16 var divs = document.querySelectorAll('div.expected-data');	20 var divs = document.querySelectorAll('div[expected-data]');

17 for (var i = 0; i < divs.length; ++i) {	21 for (var i = 0; i < divs.length; ++i) {

18 shouldBe('divs[i].style.height', 'PREFIX + divs[i].getAttribute("expecte d-data")');	22 shouldBe('divs[i].style.height', 'divs[i].getAttribute("expected-data")' );

19 shouldBe('divs[i].style.minHeight', 'PREFIX + divs[i].getAttribute("expe cted-data")');	23 shouldBe('divs[i].style.minHeight', 'divs[i].getAttribute("expected-data ")');

20 shouldBe('divs[i].style.maxHeight', 'PREFIX + divs[i].getAttribute("expe cted-data")');	24 shouldBe('divs[i].style.maxHeight', 'divs[i].getAttribute("expected-data ")');

21 }	25 }

22	26

23 var KEYWORDS = ['min-content', 'max-content', 'fill-available', 'fit-conten t'];	27 var PREFIXED_KEYWORDS = ['min-content', 'max-content', 'fill-available', 'f it-content'];
	leviw_travelin_and_unemployed 2015/08/19 18:38:00 Do you mean to have these prefixed here? Do you mean to have these prefixed here? cbiesinger 2015/08/19 18:41:46 Oh, that'll be much simpler. Let me make that chan Show quoted text On 2015/08/19 18:38:00, leviw wrote: > Do you mean to have these prefixed here? Oh, that'll be much simpler. Let me make that change...
	28 var KEYWORDS = ['min-content', 'max-content', 'fit-content'];

24 var div;	29 var div;

25	30

26 KEYWORDS.forEach(function(keyword) {	31 PREFIXED_KEYWORDS.forEach(function(keyword) {

27 div = document.createElement('div');	32 div = document.createElement('div');

28 div.style.height = PREFIX + keyword;	33 div.style.height = PREFIX + keyword;

29 div.style.minHeight = PREFIX + keyword;	34 div.style.minHeight = PREFIX + keyword;

30 div.style.maxHeight = PREFIX + keyword;	35 div.style.maxHeight = PREFIX + keyword;

31 shouldBe('div.style.height', '"' + PREFIX + keyword + '"');	36 shouldBe('div.style.height', '"' + PREFIX + keyword + '"');

32 shouldBe('div.style.minHeight', '"' + PREFIX + keyword + '"');	37 shouldBe('div.style.minHeight', '"' + PREFIX + keyword + '"');

33 shouldBe('div.style.maxHeight', '"' + PREFIX + keyword + '"');	38 shouldBe('div.style.maxHeight', '"' + PREFIX + keyword + '"');

34 });	39 });

	40 KEYWORDS.forEach(function(keyword) {

	41 div = document.createElement('div');

	42 div.style.height = keyword;

	43 div.style.minHeight = keyword;

	44 div.style.maxHeight = keyword;

	45 shouldBe('div.style.height', '"' + keyword + '"');

	46 shouldBe('div.style.minHeight', '"' + keyword + '"');

	47 shouldBe('div.style.maxHeight', '"' + keyword + '"');

	48 });

	49

35 </script>	50 </script>

36	51

OLD	NEW