Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12937016: Rename AutofillWebDataServiceImpl --> AutofillWebDataService. (Closed)

Created:
7 years, 9 months ago by Cait (Slow)
Modified:
7 years, 9 months ago
CC:
chromium-reviews, Raman Kakilate, akalin, Raghu Simha, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, markusheintz_, Ilya Sherman, haitaol1, tim (not reviewing)
Visibility:
Public.

Description

Rename AutofillWebDataServiceImpl --> AutofillWebDataService. Depends on https://codereview.chromium.org/12987023/ TBR=ben@chromium.org (API changes) BUG=181277 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190879

Patch Set 1 #

Patch Set 2 : Remove c/b/api/autofill_webdata_service.h #

Total comments: 2

Patch Set 3 : Clean up #

Patch Set 4 : More clean up #

Total comments: 1

Patch Set 5 : nit #

Patch Set 6 : Fix DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -703 lines) Patch
M chrome/browser/api/webdata/autofill_web_data_service.h View 1 1 chunk +0 lines, -49 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/webdata/autocomplete_syncable_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/autocomplete_syncable_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/autofill_profile_syncable_service.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/webdata/autofill_web_data_service.h View 1 2 3 4 4 chunks +35 lines, -11 lines 0 comments Download
A + chrome/browser/webdata/autofill_web_data_service.cc View 1 2 3 4 18 chunks +49 lines, -59 lines 0 comments Download
D chrome/browser/webdata/autofill_web_data_service_impl.h View 1 2 3 1 chunk +0 lines, -95 lines 0 comments Download
D chrome/browser/webdata/autofill_web_data_service_impl.cc View 1 2 3 4 1 chunk +0 lines, -457 lines 0 comments Download
M chrome/browser/webdata/web_data_service_factory.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/webdata/web_data_service_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M components/autofill/browser/DEPS View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M components/autofill/browser/autocomplete_history_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autocomplete_history_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/browser/personal_data_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/personal_data_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Cait (Slow)
Another AutofillWebData clean-up change. David: PTAL at c/b/webdata/ (I think the only non-renaming change is ...
7 years, 9 months ago (2013-03-25 21:41:28 UTC) #1
kaiwang
DEPS lgtm https://codereview.chromium.org/12937016/diff/2001/chrome/browser/webdata/autofill_web_data_service.cc File chrome/browser/webdata/autofill_web_data_service.cc (right): https://codereview.chromium.org/12937016/diff/2001/chrome/browser/webdata/autofill_web_data_service.cc#newcode320 chrome/browser/webdata/autofill_web_data_service.cc:320: AutofillWebDataService::RemoveAutofillProfileImpl( one line? Also applies to functions ...
7 years, 9 months ago (2013-03-25 23:21:25 UTC) #2
Cait (Slow)
https://codereview.chromium.org/12937016/diff/2001/chrome/browser/webdata/autofill_web_data_service.cc File chrome/browser/webdata/autofill_web_data_service.cc (right): https://codereview.chromium.org/12937016/diff/2001/chrome/browser/webdata/autofill_web_data_service.cc#newcode320 chrome/browser/webdata/autofill_web_data_service.cc:320: AutofillWebDataService::RemoveAutofillProfileImpl( On 2013/03/25 23:21:25, kaiwang wrote: > one line? ...
7 years, 9 months ago (2013-03-26 14:55:03 UTC) #3
dhollowa
lgtm https://codereview.chromium.org/12937016/diff/10001/chrome/browser/webdata/autofill_web_data_service.h File chrome/browser/webdata/autofill_web_data_service.h (right): https://codereview.chromium.org/12937016/diff/10001/chrome/browser/webdata/autofill_web_data_service.h#newcode37 chrome/browser/webdata/autofill_web_data_service.h:37: // nit: no need for empty comment line.
7 years, 9 months ago (2013-03-26 15:12:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/12937016/10003
7 years, 9 months ago (2013-03-26 22:30:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/12937016/32001
7 years, 9 months ago (2013-03-26 23:29:52 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-27 09:06:50 UTC) #7
Message was sent while issue was closed. 
Change committed as 190879

Powered by Google App Engine
This is Rietveld 408576698