Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1293593005: Turn v8.h into a normal header. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-fdlibm
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turn v8.h into a normal header. R=bmeurer@chromium.org Committed: https://crrev.com/95845ad42116a111450e1a3ee738b5c13035055d Cr-Commit-Position: refs/heads/master@{#30265}

Patch Set 1 #

Patch Set 2 : One more addition. Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -18 lines) Patch
M src/DEPS View 1 chunk +4 lines, -3 lines 0 comments Download
D src/compiler/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M src/interpreter/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/v8.h View 2 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
LGTM!!
5 years, 4 months ago (2015-08-20 05:34:55 UTC) #1
rmcilroy
On 2015/08/20 05:34:55, Benedikt Meurer wrote: > LGTM!! Lgtm
5 years, 4 months ago (2015-08-20 09:21:44 UTC) #2
Michael Starzinger
5 years, 4 months ago (2015-08-20 09:21:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293593005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293593005/20001
5 years, 4 months ago (2015-08-20 09:23:07 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-20 09:24:30 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 09:24:48 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/95845ad42116a111450e1a3ee738b5c13035055d
Cr-Commit-Position: refs/heads/master@{#30265}

Powered by Google App Engine
This is Rietveld 408576698