Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: src/DEPS

Issue 1293593005: Turn v8.h into a normal header. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-fdlibm
Patch Set: One more addition. Rebased. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/DEPS
diff --git a/src/DEPS b/src/DEPS
index 4b95456a17d618b02394ddc740d23e4af4a60ad0..7350f61f9f2b755481502b2e201e535055da25e2 100644
--- a/src/DEPS
+++ b/src/DEPS
@@ -14,9 +14,10 @@ include_rules = [
specific_include_rules = {
".*\.h": [
- # Note that src/v8.h is the top header for some .cc files, it shouldn't be
- # included in any .h files though. In the long run we should make src/v8.h
- # act like any normal header file, instead of a grab-bag include.
+ # Note that src/v8.h by now is a regular header file, it doesn't provide
+ # any special declarations besides the V8 class. There should be no need
+ # for including it in any .h files though. This rule is just a reminder,
+ # and can be removed once the dust has settled.
"-src/v8.h",
],
"d8\.cc": [
« no previous file with comments | « no previous file | src/compiler/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698