Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1293593004: Introduce enum class TextAffinity as replacement of enum EAffinity (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, szager+layoutwatch_chromium.org, eae+blinkwatch, fs, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, krit, aboxhall, blink-reviews-html_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, je_julie, jchaffraix+rendering, gyuyoung2, rwlbuis, zoltan1, sof, dmazzoni, blink-reviews-rendering, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, nektarios, f(malita), groby+blinkspell_chromium.org, Stephen Chennney, yoichio
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce enum class TextAffinity as replacement of enum EAffinity This patch introduces enum class |TextAffinity| as replacement of enum |EAffinity| and rename |DOWNSTREAM| and |UPSTREAM| members to capitalized name |Downstream| and |Upstream| to follow Blink coding style for improving code health. BUG=522038 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200823

Patch Set 1 : 2015-08-19T18:09:55 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -146 lines) Patch
M Source/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/DOMSelection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/EditingUtilities.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/EditingUtilities.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/Editor.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/FrameSelection.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 6 chunks +7 lines, -6 lines 0 comments Download
M Source/core/editing/InputMethodController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Position.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/Position.cpp View 5 chunks +7 lines, -6 lines 0 comments Download
M Source/core/editing/PositionWithAffinity.h View 2 chunks +5 lines, -3 lines 0 comments Download
M Source/core/editing/PositionWithAffinity.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/RenderedPosition.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/editing/RenderedPosition.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/TextAffinity.h View 1 chunk +4 lines, -6 lines 4 comments Download
M Source/core/editing/VisiblePosition.h View 5 chunks +8 lines, -7 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 4 chunks +16 lines, -12 lines 0 comments Download
M Source/core/editing/VisibleSelection.h View 6 chunks +16 lines, -15 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 6 chunks +7 lines, -6 lines 0 comments Download
M Source/core/editing/VisibleUnitsTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/commands/ApplyBlockElementCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/commands/BreakBlockquoteCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/commands/CompositeEditCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/commands/CreateLinkCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/commands/DeleteSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/commands/EditorCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/commands/IndentOutdentCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/commands/InsertLineBreakCommand.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/commands/TypingCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/spellcheck/SpellChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextFormControlElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutObject.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutText.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutTreeAsText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/PendingSelection.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/PendingSelection.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGInlineText.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/accessibility/AXLayoutObject.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293593004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293593004/1
5 years, 4 months ago (2015-08-19 09:12:47 UTC) #2
yosin_UTC9
PTAL Sorry for big patch. m(_ _)m However, it is smaller than original patch (254 ...
5 years, 4 months ago (2015-08-19 09:46:43 UTC) #4
tkent
https://codereview.chromium.org/1293593004/diff/1/Source/core/editing/TextAffinity.h File Source/core/editing/TextAffinity.h (right): https://codereview.chromium.org/1293593004/diff/1/Source/core/editing/TextAffinity.h#newcode45 Source/core/editing/TextAffinity.h:45: inline NSSelectionAffinity kit(blink::TextAffinity affinity) Is this used now? https://codereview.chromium.org/1293593004/diff/1/Source/core/editing/TextAffinity.h#newcode50 ...
5 years, 4 months ago (2015-08-19 09:50:52 UTC) #5
tkent
lgtm
5 years, 4 months ago (2015-08-19 09:56:40 UTC) #6
yosin_UTC9
Thanks for reviewing! https://codereview.chromium.org/1293593004/diff/1/Source/core/editing/TextAffinity.h File Source/core/editing/TextAffinity.h (right): https://codereview.chromium.org/1293593004/diff/1/Source/core/editing/TextAffinity.h#newcode45 Source/core/editing/TextAffinity.h:45: inline NSSelectionAffinity kit(blink::TextAffinity affinity) On 2015/08/19 ...
5 years, 4 months ago (2015-08-19 10:03:18 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-19 12:48:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293593004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293593004/1
5 years, 4 months ago (2015-08-19 12:56:28 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 13:00:47 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200823

Powered by Google App Engine
This is Rietveld 408576698