Source/core/editing/commands/CreateLinkCommand.cpp - Issue 1293593004: Introduce enum class TextAffinity as replacement of enum EAffinity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/commands/CreateLinkCommand.cpp

Issue 1293593004: Introduce enum class TextAffinity as replacement of enum EAffinity (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-08-19T18:09:55 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/editing/TextAffinity.h ('K') | « Source/core/editing/commands/CompositeEditCommand.cpp ('k') | Source/core/editing/commands/DeleteSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/commands/CreateLinkCommand.cpp

diff --git a/Source/core/editing/commands/CreateLinkCommand.cpp b/Source/core/editing/commands/CreateLinkCommand.cpp

index 309773b032b2cb9f0c8955d0c430176ae7603444..b5fe600f0e1ea66aee2cd6125b1b9d4e36cd05d9 100644

--- a/Source/core/editing/commands/CreateLinkCommand.cpp

+++ b/Source/core/editing/commands/CreateLinkCommand.cpp

@@ -51,7 +51,7 @@ void CreateLinkCommand::doApply()

insertNodeAt(anchorElement.get(), endingSelection().start());

RefPtrWillBeRawPtr<Text> textNode = Text::create(document(), m_url);

appendNode(textNode.get(), anchorElement.get());

- setEndingSelection(VisibleSelection(positionInParentBeforeNode(*anchorElement), positionInParentAfterNode(*anchorElement), DOWNSTREAM, endingSelection().isDirectional()));

+ setEndingSelection(VisibleSelection(positionInParentBeforeNode(*anchorElement), positionInParentAfterNode(*anchorElement), TextAffinity::Downstream, endingSelection().isDirectional()));

}