Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1293533003: [simd.js] Macro-ize more SIMD code (1). (Closed)

Created:
5 years, 4 months ago by bbudge
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[simd.js] Macro-ize more SIMD code. Use macros for factory functions, and in hydrogen code stubs. LOG=N BUG=v8:4124 Committed: https://crrev.com/7f6460943249a8f1fe62654689e57fab09291b58 Cr-Commit-Position: refs/heads/master@{#30206}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -129 lines) Patch
M src/code-stubs-hydrogen.cc View 1 chunk +24 lines, -70 lines 3 comments Download
M src/factory.h View 1 chunk +6 lines, -14 lines 0 comments Download
M src/factory.cc View 1 chunk +8 lines, -45 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
bbudge
https://codereview.chromium.org/1293533003/diff/1/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (right): https://codereview.chromium.org/1293533003/diff/1/src/code-stubs-hydrogen.cc#newcode389 src/code-stubs-hydrogen.cc:389: is_##type.Else(); { I had to put the opening brace ...
5 years, 4 months ago (2015-08-17 11:58:43 UTC) #2
Jarin
lgtm. I cannot shake the feeling that the hydrogen part could look much better if ...
5 years, 4 months ago (2015-08-17 13:00:22 UTC) #4
bbudge
https://codereview.chromium.org/1293533003/diff/1/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (left): https://codereview.chromium.org/1293533003/diff/1/src/code-stubs-hydrogen.cc#oldcode439 src/code-stubs-hydrogen.cc:439: Push(Add<HConstant>(factory->undefined_string())); I didn't notice before but I inadvertently changed ...
5 years, 4 months ago (2015-08-17 13:03:57 UTC) #5
bbudge
https://codereview.chromium.org/1293533003/diff/1/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (left): https://codereview.chromium.org/1293533003/diff/1/src/code-stubs-hydrogen.cc#oldcode439 src/code-stubs-hydrogen.cc:439: Push(Add<HConstant>(factory->undefined_string())); On 2015/08/17 13:03:57, bbudge wrote: > I didn't ...
5 years, 4 months ago (2015-08-17 13:05:54 UTC) #6
Benedikt Meurer
LGTM
5 years, 4 months ago (2015-08-17 14:22:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293533003/1
5 years, 4 months ago (2015-08-17 18:17:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-17 18:58:42 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 18:59:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f6460943249a8f1fe62654689e57fab09291b58
Cr-Commit-Position: refs/heads/master@{#30206}

Powered by Google App Engine
This is Rietveld 408576698