[simd.js] Macro-ize more SIMD code (1).

src/code-stubs-hydrogen.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/bailout-reason.h"
 #include "src/code-stubs.h"
 #include "src/field-index.h"
 #include "src/hydrogen.h"
@@ skipping 362 matching lines @@
             HConstant* js_function_proxy =
                 Add<HConstant>(JS_FUNCTION_PROXY_TYPE);
             is_function.If<HCompareNumericAndBranch>(instance_type, js_function,
                                                      Token::EQ);
             is_function.OrIf<HCompareNumericAndBranch>(
                 instance_type, js_function_proxy, Token::EQ);
             is_function.Then();
             { Push(Add<HConstant>(factory->function_string())); }
             is_function.Else();
             {
-              IfBuilder is_float32x4(this);
-              is_float32x4.If<HCompareObjectEqAndBranch>(
-                  map, Add<HConstant>(factory->float32x4_map()));
-              is_float32x4.Then();
-              { Push(Add<HConstant>(factory->float32x4_string())); }
-              is_float32x4.Else();
+#define SIMD128_BUILDER_OPEN(TYPE, Type, type, lane_count, lane_type) \
+  IfBuilder is_##type(this);                                          \
+  is_##type.If<HCompareObjectEqAndBranch>(                            \
+      map, Add<HConstant>(factory->type##_map()));                    \
+  is_##type.Then();                                                   \
+  { Push(Add<HConstant>(factory->type##_string())); }                 \
+  is_##type.Else(); {

[bbudge, 2015/08/17 11:58:43]

I had to put the opening brace on this line to appease the linter in the
presubmit step.

+              SIMD128_TYPES(SIMD128_BUILDER_OPEN)
+#undef SIMD128_BUILDER_OPEN
+              // Is it an undetectable object?
+              IfBuilder is_undetectable(this);
+              is_undetectable.If<HIsUndetectableAndBranch>(object);
+              is_undetectable.Then();
               {
-                IfBuilder is_int32x4(this);
-                is_int32x4.If<HCompareObjectEqAndBranch>(
-                    map, Add<HConstant>(factory->int32x4_map()));
-                is_int32x4.Then();
-                { Push(Add<HConstant>(factory->int32x4_string())); }
-                is_int32x4.Else();
-                {
-                  IfBuilder is_bool32x4(this);
-                  is_bool32x4.If<HCompareObjectEqAndBranch>(
-                      map, Add<HConstant>(factory->bool32x4_map()));
-                  is_bool32x4.Then();
-                  { Push(Add<HConstant>(factory->bool32x4_string())); }
-                  is_bool32x4.Else();
-                  {
-                    IfBuilder is_int16x8(this);
-                    is_int16x8.If<HCompareObjectEqAndBranch>(
-                        map, Add<HConstant>(factory->int16x8_map()));
-                    is_int16x8.Then();
-                    { Push(Add<HConstant>(factory->int16x8_string())); }
-                    is_int16x8.Else();
-                    {
-                      IfBuilder is_bool16x8(this);
-                      is_bool16x8.If<HCompareObjectEqAndBranch>(
-                          map, Add<HConstant>(factory->bool16x8_map()));
-                      is_bool16x8.Then();
-                      { Push(Add<HConstant>(factory->bool16x8_string())); }
-                      is_bool16x8.Else();
-                      {
-                        IfBuilder is_int8x16(this);
-                        is_int8x16.If<HCompareObjectEqAndBranch>(
-                            map, Add<HConstant>(factory->int8x16_map()));
-                        is_int8x16.Then();
-                        { Push(Add<HConstant>(factory->int8x16_string())); }
-                        is_int8x16.Else();
-                        {
-                          IfBuilder is_bool8x16(this);
-                          is_bool8x16.If<HCompareObjectEqAndBranch>(
-                              map, Add<HConstant>(factory->bool8x16_map()));
-                          is_bool8x16.Then();
-                          { Push(Add<HConstant>(factory->bool8x16_string())); }
-                          is_bool8x16.Else();
-                          {
-                            // Is it an undetectable object?
-                            IfBuilder is_undetectable(this);
-                            is_undetectable.If<HIsUndetectableAndBranch>(
-                                object);
-                            is_undetectable.Then();
-                            {
-                              // typeof an undetectable object is 'undefined'.
-                              Push(Add<HConstant>(factory->undefined_string()));

[bbudge, 2015/08/17 13:03:57]

I didn't notice before but I inadvertently changed this. Fixing before landing.

[bbudge, 2015/08/17 13:05:54]

Ugh, never mind, I was confused reading the diff.

-                            }
-                            is_undetectable.Else();
-                            {
-                              // For any kind of object not handled above, the
-                              // spec rule for host objects gives that it is
-                              // okay to return "object".
-                              Push(object_string);
-                            }
-                          }
-                        }
-                      }
-                    }
-                  }
-                }
+                // typeof an undetectable object is 'undefined'.
+                Push(Add<HConstant>(factory->undefined_string()));
               }
+              is_undetectable.Else();
+              {
+                // For any kind of object not handled above, the spec rule for
+                // host objects gives that it is okay to return "object".
+                Push(object_string);
+              }
+#define SIMD128_BUILDER_CLOSE(TYPE, Type, type, lane_count, lane_type) }
+              SIMD128_TYPES(SIMD128_BUILDER_CLOSE)
+#undef SIMD128_BUILDER_CLOSE
             }
             is_function.End();
           }
           is_symbol.End();
         }
         is_oddball.End();
       }
       is_string.End();
     }
     is_number.End();
@@ skipping 1788 matching lines @@
   return Pop();
 }
 
 
 Handle<Code> KeyedLoadGenericStub::GenerateCode() {
   return DoGenerateCode(this);
 }
 
 }  // namespace internal
 }  // namespace v8