Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 129343003: Catch TabCrashException that may occur as we poll for oobe disappearing. (Closed)

Created:
6 years, 11 months ago by achuithb
Modified:
6 years, 11 months ago
Reviewers:
Tim Song
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Catch TabCrashException that may occur as we poll for oobe disappearing. We access oobe here as it is going away: https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py&q=oobe&l=343 BUG=chromium:332545 TEST=manual NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243690

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/telemetry/telemetry/core/backends/chrome/misc_web_contents_backend.py View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
achuithb
Tim, let me know what you think.
6 years, 11 months ago (2014-01-08 22:43:23 UTC) #1
Tim Song
LGTM. This crash due to a race condition if the oobe goes away while we're ...
6 years, 11 months ago (2014-01-08 22:48:53 UTC) #2
achuithb
On 2014/01/08 22:48:53, Tim Song wrote: > LGTM. This crash due to a race condition ...
6 years, 11 months ago (2014-01-08 22:49:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/129343003/1
6 years, 11 months ago (2014-01-08 22:58:11 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 23:16:31 UTC) #5
Message was sent while issue was closed.
Change committed as 243690

Powered by Google App Engine
This is Rietveld 408576698