Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/misc_web_contents_backend.py

Issue 129343003: Catch TabCrashException that may occur as we poll for oobe disappearing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/backends/chrome/misc_web_contents_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/misc_web_contents_backend.py b/tools/telemetry/telemetry/core/backends/chrome/misc_web_contents_backend.py
index f2327c0e6106aaeb9721839d95b627c16dd62bcc..891366b2643e766324285d4465124964967e7117 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/misc_web_contents_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/misc_web_contents_backend.py
@@ -3,6 +3,7 @@
# found in the LICENSE file.
import json
+from telemetry.core import exceptions
from telemetry.core import web_contents
from telemetry.core.backends.chrome import inspector_backend
@@ -17,7 +18,10 @@ class MiscWebContentsBackend(object):
if oobe_web_contents_info:
debugger_url = oobe_web_contents_info.get('webSocketDebuggerUrl')
if debugger_url:
- inspector = self._CreateInspectorBackend(debugger_url)
+ try:
+ inspector = self._CreateInspectorBackend(debugger_url)
+ except exceptions.TabCrashException:
+ return None
return web_contents.WebContents(inspector)
return None
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698