Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1293413003: No need to re-declare pure virtual name(). (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

No need to re-declare pure virtual name(). Fixes inconsistent override warning. BUG=skia: TBR=bsalomon@google.com Committed: https://skia.googlesource.com/skia/+/790d74f7c1db73e2938eee6a6eb78bc29be7b851

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M include/gpu/GrFragmentProcessor.h View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
mtklein_C
5 years, 4 months ago (2015-08-19 17:17:45 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293413003/1
5 years, 4 months ago (2015-08-19 17:20:00 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-19 17:26:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293413003/1
5 years, 4 months ago (2015-08-19 18:02:24 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/2038)
5 years, 4 months ago (2015-08-19 18:03:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293413003/1
5 years, 4 months ago (2015-08-19 18:05:07 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 18:05:42 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/790d74f7c1db73e2938eee6a6eb78bc29be7b851

Powered by Google App Engine
This is Rietveld 408576698