Change to use arena allocation for function-local data in parser.

src/IceDefs.h

Index: src/IceDefs.h
diff --git a/src/IceDefs.h b/src/IceDefs.h
index 1908a034f4c19b151a9faa98a44a4bd2019f655f..d7f9c028fdb720282767bdb4c7c4ca895d54b344 100644
--- a/src/IceDefs.h
+++ b/src/IceDefs.h
@@ -145,10 +145,12 @@ typedef llvm::ilist<Inst> InstList;
 typedef InstList PhiList;
 typedef InstList AssignList;
 // VarList and NodeList are arena-allocated from the Cfg's allocator.

[Jim Stichnoth, 2015/08/20 20:11:11]

In conjunction with my comment below, you can probably change this comment to
something like:
// Containers that are arena-allocated from the Cfg's allocator.

and add a comment to the next section:
// Containers that use the default (global) allocator.

[Karl, 2015/08/20 20:24:19]

Done.

+typedef std::vector<Operand *, CfgLocalAllocator<Operand *>> OperandList;
 typedef std::vector<Variable *, CfgLocalAllocator<Variable *>> VarList;
 typedef std::vector<CfgNode *, CfgLocalAllocator<CfgNode *>> NodeList;
 typedef std::vector<Constant *> ConstantList;

[Jim Stichnoth, 2015/08/20 20:11:11]

Maybe move ConstantList below the blank line.  It's looking like the first
section is CfgLocal vectors, and the second section is traditional vectors.

[Karl, 2015/08/20 20:24:19]

Done.

 
+typedef std::vector<FunctionDeclaration *> FunctionDeclarationList;
 typedef std::vector<VariableDeclaration *> VariableDeclarationList;
 
 /// SizeT is for holding small-ish limits like number of source