Change to use arena allocation for function-local data in parser.

src/IceDefs.h

 //===- subzero/src/IceDefs.h - Common Subzero declarations ------*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 126 matching lines @@
 }
 
 #define ENABLE_MAKE_UNIQUE friend struct ::Ice::Internal::MakeUniqueEnabler
 
 typedef std::string IceString;
 typedef llvm::ilist<Inst> InstList;
 // Ideally PhiList would be llvm::ilist<InstPhi>, and similar for
 // AssignList, but this runs into issues with SFINAE.
 typedef InstList PhiList;
 typedef InstList AssignList;
 // VarList and NodeList are arena-allocated from the Cfg's allocator.

[Jim Stichnoth, 2015/08/20 20:11:11]

In conjunction with my comment below, you can probably change this comment to
something like:
// Containers that are arena-allocated from the Cfg's allocator.

and add a comment to the next section:
// Containers that use the default (global) allocator.

[Karl, 2015/08/20 20:24:19]

Done.

+typedef std::vector<Operand *, CfgLocalAllocator<Operand *>> OperandList;
 typedef std::vector<Variable *, CfgLocalAllocator<Variable *>> VarList;
 typedef std::vector<CfgNode *, CfgLocalAllocator<CfgNode *>> NodeList;
 typedef std::vector<Constant *> ConstantList;

[Jim Stichnoth, 2015/08/20 20:11:11]

Maybe move ConstantList below the blank line.  It's looking like the first
section is CfgLocal vectors, and the second section is traditional vectors.

[Karl, 2015/08/20 20:24:19]

Done.

 
+typedef std::vector<FunctionDeclaration *> FunctionDeclarationList;
 typedef std::vector<VariableDeclaration *> VariableDeclarationList;
 
 /// SizeT is for holding small-ish limits like number of source
 /// operands in an instruction.  It is used instead of size_t (which
 /// may be 64-bits wide) when we want to save space.
 typedef uint32_t SizeT;
 
 /// InstNumberT is for holding an instruction number.  Instruction
 /// numbers are used for representing Variable live ranges.
 typedef int32_t InstNumberT;
@@ skipping 109 matching lines @@
 llvm::iterator_range<typename T::reverse_iterator> reverse_range(T &Container) {
   return llvm::make_range(Container.rbegin(), Container.rend());
 }
 
 /// Options for pooling and randomization of immediates.
 enum RandomizeAndPoolImmediatesEnum { RPI_None, RPI_Randomize, RPI_Pool };
 
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICEDEFS_H