Change to use arena allocation for function-local data in parser.

Change to use arena allocation for function-local data in parser.

Changes to use arena allocator of the CFG associated with function, for
vectors in the function parser.

BUG=None
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=209318af2b035d729225c5d86dbeb27935ebfafb

[Karl, 2015-08-20 15:03:17]

kschimpf@google.com changed reviewers:
+ jvoung@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2015-08-20 20:11:11]

lgtm

https://codereview.chromium.org/1293343003/diff/30001/src/IceDefs.h
File src/IceDefs.h (right):

https://codereview.chromium.org/1293343003/diff/30001/src/IceDefs.h#newcode147
src/IceDefs.h:147: // VarList and NodeList are arena-allocated from the Cfg's
allocator.
In conjunction with my comment below, you can probably change this comment to
something like:
// Containers that are arena-allocated from the Cfg's allocator.

and add a comment to the next section:
// Containers that use the default (global) allocator.

https://codereview.chromium.org/1293343003/diff/30001/src/IceDefs.h#newcode151
src/IceDefs.h:151: typedef std::vector<Constant *> ConstantList;
Maybe move ConstantList below the blank line.  It's looking like the first
section is CfgLocal vectors, and the second section is traditional vectors.

https://codereview.chromium.org/1293343003/diff/30001/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1293343003/diff/30001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:1233: Func =
Ice::Cfg::create(getTranslator().getContext(),
It would probably be good to add a comment here explaining that a Cfg is created
even when IR generation is disabled just to install a CfgLocalAllocator for
various internal containers.

[Karl, 2015-08-20 20:24:06]

Committed patchset #4 (id:50001) manually as
209318af2b035d729225c5d86dbeb27935ebfafb (presubmit successful).

[Karl, 2015-08-20 20:24:19]

https://codereview.chromium.org/1293343003/diff/30001/src/IceDefs.h
File src/IceDefs.h (right):

https://codereview.chromium.org/1293343003/diff/30001/src/IceDefs.h#newcode147
src/IceDefs.h:147: // VarList and NodeList are arena-allocated from the Cfg's
allocator.
On 2015/08/20 20:11:11, stichnot wrote:
> In conjunction with my comment below, you can probably change this comment to
> something like:
> // Containers that are arena-allocated from the Cfg's allocator.
> 
> and add a comment to the next section:
> // Containers that use the default (global) allocator.

Done.

https://codereview.chromium.org/1293343003/diff/30001/src/IceDefs.h#newcode151
src/IceDefs.h:151: typedef std::vector<Constant *> ConstantList;
On 2015/08/20 20:11:11, stichnot wrote:
> Maybe move ConstantList below the blank line.  It's looking like the first
> section is CfgLocal vectors, and the second section is traditional vectors.

Done.

https://codereview.chromium.org/1293343003/diff/30001/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1293343003/diff/30001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:1233: Func =
Ice::Cfg::create(getTranslator().getContext(),
On 2015/08/20 20:11:11, stichnot wrote:
> It would probably be good to add a comment here explaining that a Cfg is
created
> even when IR generation is disabled just to install a CfgLocalAllocator for
> various internal containers.

Done.