Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1293253002: Connect WebUSB client interface to the devices app (Closed)

Created:
5 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 4 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Connect WebUSB client interface to the devices app This provides a basic WebUSB client interface in content/renderer. Most of the interface is unimplemented, but this CL hooks up navigator.usb.getDevices() to the browser's Mojo devices app to enumerate available USB devices. BUG=492204 Committed: https://crrev.com/d926098e2e2be270c80a5ba25ab8a611b80b8556 Cr-Commit-Position: refs/heads/master@{#344881}

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Initialize Mojo in RenderViewTests #

Patch Set 4 : add missing device/core dep for gyp #

Patch Set 5 : no android #

Patch Set 6 : #

Patch Set 7 : Fix memory leak in WeakBindingSet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+888 lines, -13 lines) Patch
A content/child/scoped_web_callbacks.h View 1 2 1 chunk +107 lines, -0 lines 0 comments Download
M content/content_child.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 5 4 chunks +15 lines, -0 lines 0 comments Download
M content/public/test/render_view_test.cc View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/BUILD.gn View 1 2 3 4 5 2 chunks +14 lines, -1 line 0 comments Download
M content/renderer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 3 5 chunks +12 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 7 chunks +30 lines, -10 lines 0 comments Download
A content/renderer/usb/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A + content/renderer/usb/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A content/renderer/usb/type_converters.h View 1 chunk +105 lines, -0 lines 0 comments Download
A content/renderer/usb/type_converters.cc View 1 1 chunk +259 lines, -0 lines 0 comments Download
A content/renderer/usb/web_usb_client_impl.h View 1 chunk +36 lines, -0 lines 0 comments Download
A content/renderer/usb/web_usb_client_impl.cc View 1 1 chunk +102 lines, -0 lines 0 comments Download
A content/renderer/usb/web_usb_device_impl.h View 1 1 chunk +80 lines, -0 lines 0 comments Download
A content/renderer/usb/web_usb_device_impl.cc View 1 chunk +113 lines, -0 lines 0 comments Download
M device/devices_app/devices_app.gyp View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M device/devices_app/usb/device_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/weak_binding_set.h View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 45 (23 generated)
Ken Rockot(use gerrit already)
reillyg: Could you please take a look at device/ and content/renderer/usb/. The majority of this ...
5 years, 4 months ago (2015-08-17 21:41:32 UTC) #4
Reilly Grant (use Gerrit)
https://codereview.chromium.org/1293253002/diff/40001/content/renderer/usb/OWNERS File content/renderer/usb/OWNERS (right): https://codereview.chromium.org/1293253002/diff/40001/content/renderer/usb/OWNERS#newcode2 content/renderer/usb/OWNERS:2: rockot@chromium.oth oth -> org https://codereview.chromium.org/1293253002/diff/40001/content/renderer/usb/type_converters.cc File content/renderer/usb/type_converters.cc (right): https://codereview.chromium.org/1293253002/diff/40001/content/renderer/usb/type_converters.cc#newcode73 ...
5 years, 4 months ago (2015-08-17 22:41:36 UTC) #5
Ken Rockot(use gerrit already)
https://codereview.chromium.org/1293253002/diff/40001/content/renderer/usb/OWNERS File content/renderer/usb/OWNERS (right): https://codereview.chromium.org/1293253002/diff/40001/content/renderer/usb/OWNERS#newcode2 content/renderer/usb/OWNERS:2: rockot@chromium.oth On 2015/08/17 22:41:36, reillyg wrote: > oth -> ...
5 years, 4 months ago (2015-08-17 22:50:07 UTC) #7
Reilly Grant (use Gerrit)
lgtm
5 years, 4 months ago (2015-08-17 22:56:57 UTC) #8
jam
lgtm https://codereview.chromium.org/1293253002/diff/80001/content/child/scoped_web_callbacks.h File content/child/scoped_web_callbacks.h (right): https://codereview.chromium.org/1293253002/diff/80001/content/child/scoped_web_callbacks.h#newcode15 content/child/scoped_web_callbacks.h:15: // simultaenously dealing with the following two conditions: ...
5 years, 4 months ago (2015-08-18 05:14:32 UTC) #9
Ken Rockot(use gerrit already)
https://codereview.chromium.org/1293253002/diff/80001/content/child/scoped_web_callbacks.h File content/child/scoped_web_callbacks.h (right): https://codereview.chromium.org/1293253002/diff/80001/content/child/scoped_web_callbacks.h#newcode15 content/child/scoped_web_callbacks.h:15: // simultaenously dealing with the following two conditions: On ...
5 years, 4 months ago (2015-08-18 22:29:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293253002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293253002/180001
5 years, 4 months ago (2015-08-19 22:49:38 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/41941)
5 years, 4 months ago (2015-08-20 00:43:06 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293253002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293253002/200001
5 years, 4 months ago (2015-08-20 17:43:20 UTC) #19
Reilly Grant (use Gerrit)
5 years, 4 months ago (2015-08-20 17:44:33 UTC) #22
Ken Rockot(use gerrit already)
(now with fewer debugging logs...)
5 years, 4 months ago (2015-08-20 17:46:16 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293253002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293253002/240001
5 years, 4 months ago (2015-08-20 17:46:35 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/58406)
5 years, 4 months ago (2015-08-21 00:36:48 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293253002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293253002/240001
5 years, 4 months ago (2015-08-21 18:14:28 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/59898)
5 years, 4 months ago (2015-08-21 18:39:23 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293253002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293253002/240001
5 years, 4 months ago (2015-08-21 19:15:54 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/59955)
5 years, 4 months ago (2015-08-21 19:37:16 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293253002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293253002/240001
5 years, 4 months ago (2015-08-21 19:57:10 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/59995)
5 years, 4 months ago (2015-08-21 20:20:34 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293253002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293253002/240001
5 years, 4 months ago (2015-08-21 21:18:33 UTC) #43
commit-bot: I haz the power
Committed patchset #7 (id:240001)
5 years, 4 months ago (2015-08-21 22:26:36 UTC) #44
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 22:27:28 UTC) #45
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/d926098e2e2be270c80a5ba25ab8a611b80b8556
Cr-Commit-Position: refs/heads/master@{#344881}

Powered by Google App Engine
This is Rietveld 408576698