device/devices_app/usb/device_manager_impl.cc - Issue 1293253002: Connect WebUSB client interface to the devices app

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/devices_app/usb/device_manager_impl.cc

Issue 1293253002: Connect WebUSB client interface to the devices app (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix memory leak in WeakBindingSet Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/devices_app/usb/device_manager_impl.cc

diff --git a/device/devices_app/usb/device_manager_impl.cc b/device/devices_app/usb/device_manager_impl.cc

index fb783fced9d03b6a57650099ced170b3de9a1d1c..b8f348e24923cd208962383b946fabb294fc7de8 100644

--- a/device/devices_app/usb/device_manager_impl.cc

+++ b/device/devices_app/usb/device_manager_impl.cc

@@ -32,7 +32,7 @@ void OnGetDevicesOnServiceThread(

const std::vector<scoped_refptr<UsbDevice>>& devices) {

mojo::Array<DeviceInfoPtr> mojo_devices(0);

for (size_t i = 0; i < devices.size(); ++i) {

- if (UsbDeviceFilter::MatchesAny(devices[i], filters))

+ if (UsbDeviceFilter::MatchesAny(devices[i], filters) || filters.empty())

mojo_devices.push_back(DeviceInfo::From(*devices[i]));

}

callback_task_runner->PostTask(

« no previous file with comments | « device/devices_app/devices_app.gyp ('k') | mojo/common/weak_binding_set.h » ('j') | no next file with comments »